From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943084AbcJSSGm (ORCPT ); Wed, 19 Oct 2016 14:06:42 -0400 Received: from mail.kernel.org ([198.145.29.136]:59638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932327AbcJSSGl (ORCPT ); Wed, 19 Oct 2016 14:06:41 -0400 Date: Wed, 19 Oct 2016 15:06:34 -0300 From: Arnaldo Carvalho de Melo To: Steven Rostedt Cc: Namhyung Kim , Honggyu Kim , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: [PATCH 1/3] tools lib traceevent: Add -O2 option to traceevent Message-ID: <20161019180634.GG25522@kernel.org> References: <20161017141712.11932-1-hong.gyu.kim@lge.com> <20161018020109.GA6099@danjae.aot.lge.com> <20161018112953.29e2126b@gandalf.local.home> <20161019174845.GE25522@kernel.org> <20161019180548.GF25522@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161019180548.GF25522@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Oct 19, 2016 at 03:05:48PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Oct 19, 2016 at 02:48:45PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Oct 18, 2016 at 11:29:53AM -0400, Steven Rostedt escreveu: > > > On Tue, 18 Oct 2016 11:01:09 +0900 > > > Namhyung Kim wrote: > > > > > > > Hi Honggyu, > > > > > > > > You need to CC relevant maintainers when you send patches to LKML. > > > > For the libtraceevent, they are Arnaldo and Steven. You can use > > > > scripts/get_maintainer.pl for this job later. In addition running > > > > scripts/checkpatch.pl before sending patches is a good habit. > > > > > > > > Arnaldo and Steve, > > > > > > > > This is from uftrace building libtraceevent with the optimization flag > > > > and we want to fix the upstream as well. > > > > > > > > > > Acked-by: Steven Rostedt > > > > So right after applying this patch I get these new warnings, investigating... > > Some are the compiler not grokking logic where the compiler gets > confused with logic that tests one variable to use another and thinks it > is using garbage (uninitialized stuff), I tried to follow the logic and > I think it got slightly more confused than me, as I _think_ its not a > problem, but the one on the case entry for > > OLD_RINGBUF_TYPE_TIME_EXTEND > > in old_update_pointers() looks like a bug, unless some macro magic is > taking place that updates that 'lenght' variable. > > Rostedt, that -O2 unleashed some warnings, please check, I'll defer > applying those patches till it doesn't show these warnings, i.e. till > other patches fixing these issues or simply silencing the compiler with > a harmless init gets submitted, Ah, the patch I had so far shutting off most of this is: diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index 664c90c8e22b..449056e96fe6 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c @@ -3490,7 +3490,7 @@ struct event_format * pevent_find_event_by_name(struct pevent *pevent, const char *sys, const char *name) { - struct event_format *event; + struct event_format *event = NULL; int i; if (pevent->last_event && @@ -4843,7 +4843,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event char format[32]; int show_func; int len_as_arg; - int len_arg; + int len_arg = 0; int len; int ls; @@ -5102,8 +5102,8 @@ void pevent_data_lat_fmt(struct pevent *pevent, static int migrate_disable_exists; unsigned int lat_flags; unsigned int pc; - int lock_depth; - int migrate_disable; + int lock_depth = 0; + int migrate_disable = 0; int hardirq; int softirq; void *data = record->data;