From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760328AbcJTLN2 (ORCPT ); Thu, 20 Oct 2016 07:13:28 -0400 Received: from mga11.intel.com ([192.55.52.93]:14870 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753756AbcJTLN1 (ORCPT ); Thu, 20 Oct 2016 07:13:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,518,1473145200"; d="scan'208";a="1073131264" Date: Thu, 20 Oct 2016 14:13:23 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Andy Shevchenko Cc: Lee Jones , linux-kernel@vger.kernel.org, Linus Walleij Subject: Re: [PATCH v1 1/1] mfd: intel_soc_pmic_core: Use explicit name of GPIO controller Message-ID: <20161020111323.GP4329@intel.com> References: <20161020093613.45939-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161020093613.45939-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2016 at 12:36:13PM +0300, Andy Shevchenko wrote: > The Crystal Cove GPIO driver has its explicit name, i.e. crystal_cove_gpio. > > Use it explicitly to be in align with the rest of code, pretty grepping, and > prevent potential breakage if GPIO driver file name ever changed. > > Cc: Linus Walleij > Cc: Ville Syrjälä > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel_soc_pmic_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index 12d6ebb4..7fd8e87 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -34,7 +34,7 @@ static struct gpiod_lookup_table panel_gpio_table = { > .dev_id = "0000:00:02.0", > .table = { > /* Panel EN/DISABLE */ > - GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), > + GPIO_LOOKUP("crystal_cove_gpio", 94, "panel", GPIO_ACTIVE_HIGH), This looks like it would break things. The gpio_chip->label which is used for the lookup is based on KBUILD_MODNAME and the moduled is called gpio-crystalcove. > { }, > }, > }; > -- > 2.9.3 -- Ville Syrjälä Intel OTC