From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941081AbcJTNeB (ORCPT ); Thu, 20 Oct 2016 09:34:01 -0400 Received: from mail-qk0-f194.google.com ([209.85.220.194]:33642 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938478AbcJTNeA (ORCPT ); Thu, 20 Oct 2016 09:34:00 -0400 Date: Thu, 20 Oct 2016 15:33:58 +0200 From: Michal Hocko To: Vlastimil Babka Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Mel Gorman , Johannes Weiner , "Kirill A. Shutemov" , Hugh Dickins , David Rientjes Subject: Re: [RFC] fs/proc/meminfo: introduce Unaccounted statistic Message-ID: <20161020133358.GN14609@dhcp22.suse.cz> References: <20161020121149.9935-1-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161020121149.9935-1-vbabka@suse.cz> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 20-10-16 14:11:49, Vlastimil Babka wrote: [...] > Hi, I'm wondering if people would find this useful. If you think it is, and > to not make performance worse, I could also make sure in proper submission > that values are not read via global_page_state() multiple times etc... I definitely find this information useful and hate to do the math all the time but on the other hand this is quite fragile and I can imagine we can easily forget to add something there and provide a misleading information to the userspace. So I would be worried with a long term maintainability of this. -- Michal Hocko SUSE Labs