From: Andi Kleen <ak@linux.intel.com>
To: Nilay Vaish <nilayvaish@gmail.com>
Cc: Jin Yao <yao.jin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@kernel.org>,
Linux Kernel list <Linux-kernel@vger.kernel.org>,
kan.liang@intel.com
Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain
Date: Thu, 20 Oct 2016 09:48:54 -0700 [thread overview]
Message-ID: <20161020164854.GB1075@tassilo.jf.intel.com> (raw)
In-Reply-To: <CACbG309gmrJcK+Q2CjhWXBCvJh3yVOsYrc3ZsC4py36BhOcZVA@mail.gmail.com>
On Thu, Oct 20, 2016 at 11:41:11AM -0500, Nilay Vaish wrote:
> On 19 October 2016 at 17:01, Jin Yao <yao.jin@linux.intel.com> wrote:
> > diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
> > index 40ecf25..4f6bf6c 100644
> > --- a/tools/perf/util/callchain.h
> > +++ b/tools/perf/util/callchain.h
> > @@ -115,6 +115,10 @@ struct callchain_list {
> > bool unfolded;
> > bool has_children;
> > };
> > + u64 branch_count;
> > + u64 predicted_count;
> > + u64 abort_count;
>
> Can you explain what abort count is? It seems you are referring to
> miss-speculated branches. If that is the case, I would prefer that we
> replace abort by miss_speculated or miss_predicted.
abort refers to TSX aborts. It has nothing to do with branch
mispredictions.
-Andi
next prev parent reply other threads:[~2016-10-20 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 22:01 [PATCH v2 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Jin Yao
2016-10-19 22:01 ` [PATCH v2 1/6] perf report: Add branch flag to callchain cursor node Jin Yao
2016-10-19 22:01 ` [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain Jin Yao
2016-10-20 16:41 ` Nilay Vaish
2016-10-20 16:48 ` Andi Kleen [this message]
2016-10-20 17:06 ` Nilay Vaish
2016-10-20 18:20 ` Andi Kleen
2016-10-21 0:23 ` Jin, Yao
2016-10-25 18:11 ` Arnaldo Carvalho de Melo
2016-10-19 22:01 ` [PATCH v2 3/6] perf report: Create a symbol_conf flag for showing branch flag counting Jin Yao
2016-10-19 22:01 ` [PATCH v2 4/6] perf report: Show branch info in callchain entry for stdio mode Jin Yao
2016-10-19 22:01 ` [PATCH v2 5/6] perf report: Show branch info in callchain entry for browser mode Jin Yao
2016-10-19 22:01 ` [PATCH v2 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history Jin Yao
2016-10-23 14:10 ` [PATCH v2 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020164854.GB1075@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=nilayvaish@gmail.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox