From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757433AbcJTW7f (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Oct 2016 18:59:35 -0400
Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:36256 "EHLO
        ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1753959AbcJTW7d (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Oct 2016 18:59:33 -0400
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2CCIAClSwlYIGnXLHlcHAEBBAEBCgEBgz4BAQEBAR2BVIZynBcBAQEBAQEGgRuMB4o+hhsEAgKBfkQQAQIBAQEBAQEBBgEBAQEBATlFhGMBAQQ6HCMQCAMOCgklDwUlAwcaE4hRw20BAQEHAiUehVSFIIomBZoOkAKBeYgghW2Mf4QANWkGCIUMKjSJGQEBAQ
Date: Fri, 21 Oct 2016 09:59:29 +1100
From: Dave Chinner <david@fromorbit.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Hugh Dickins <hughd@google.com>, David Rientjes <rientjes@google.com>
Subject: Re: [RFC] fs/proc/meminfo: introduce Unaccounted statistic
Message-ID: <20161020225929.GP23194@dastard>
References: <20161020121149.9935-1-vbabka@suse.cz>
 <20161020133358.GN14609@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161020133358.GN14609@dhcp22.suse.cz>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 20, 2016 at 03:33:58PM +0200, Michal Hocko wrote:
> On Thu 20-10-16 14:11:49, Vlastimil Babka wrote:
> [...]
> > Hi, I'm wondering if people would find this useful. If you think it is, and
> > to not make performance worse, I could also make sure in proper submission
> > that values are not read via global_page_state() multiple times etc...
> 
> I definitely find this information useful and hate to do the math all
> the time but on the other hand this is quite fragile and I can imagine
> we can easily forget to add something there and provide a misleading
> information to the userspace. So I would be worried with a long term
> maintainability of this.

This will result in valid memory usage by subsystems like the XFS
buffer cache being reported as "unaccounted". Given this cache
(whose size is shrinker controlled) can grow to gigabytes in size
under various metadata intensive workloads, there's every chance
that such reporting will make users incorrectly think they have a
massive memory leak....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com