From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935910AbcJUTXw (ORCPT <rfc822;w@1wt.eu>);
        Fri, 21 Oct 2016 15:23:52 -0400
Received: from foss.arm.com ([217.140.101.70]:52590 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753953AbcJUTXv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Oct 2016 15:23:51 -0400
Date: Fri, 21 Oct 2016 14:23:49 -0500
From: Kim Phillips <kim.phillips@arm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, <linux-kernel@vger.kernel.org>,
        Linux Weekly News <lwn@lwn.net>, Andi Kleen <andi@firstfloor.org>,
        David Ahern <dsahern@gmail.com>, Don Zickus <dzickus@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>, Joe Mario <jmario@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "Arnaldo Carvalho de Melo" <acme@redhat.com>
Subject: Re: [PATCH] perf c2c report: Properly check data presence in
 rb_tree loop
Message-Id: <20161021142349.58a8acd24e0ef074f62836e8@arm.com>
In-Reply-To: <20161021001706.GB23970@krava>
References: <1476975876-2522-1-git-send-email-acme@kernel.org>
        <20161020180224.23b087c217663cd262ddc873@arm.com>
        <20161021001706.GB23970@krava>
Organization: ARM
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 21 Oct 2016 02:17:06 +0200
Jiri Olsa <jolsa@redhat.com> wrote:

> On Thu, Oct 20, 2016 at 06:02:24PM -0500, Kim Phillips wrote:
> 
> SNIP
> 
> > (gdb) bt
> > #0  c2c_browser__update_nr_entries (hb=<optimized out>, hb=<optimized out>) at builtin-c2c.c:2142
> > #1  perf_c2c__hists_browse (hists=0x8b2d90 <c2c+240>) at builtin-c2c.c:2287
> > #2  perf_c2c_display (session=0x205b1a0) at builtin-c2c.c:2316
> > #3  perf_c2c__report (argv=<optimized out>, argc=<optimized out>) at builtin-c2c.c:2621
> > #4  cmd_c2c (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin-c2c.c:2748
> > #5  0x000000000048df61 in run_builtin (p=p@entry=0x8be168 <commands+72>, argc=argc@entry=2, argv=argv@entry=0x7fffffffddb0)
> >     at perf.c:358
> > #6  0x00000000004249b6 in handle_internal_command (argv=0x7fffffffddb0, argc=2) at perf.c:420
> > #7  run_argv (argv=0x7fffffffdb40, argcp=0x7fffffffdb4c) at perf.c:466
> > #8  main (argc=2, argv=0x7fffffffddb0) at perf.c:610
> > (gdb) 
> > 
> > All the above work fine when run under sudo.
> 
> ugh, stupid mistake.. attached patch fixes that for me

I see it's been merged here now:

https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/c2c&id=5a1a99cd2e4e15571a74f65facf05f806d5303fd

and the updated perf-c2c-for-mingo-20161021 works, so thanks all.

Kim