From: Chris Wilson <chris@chris-wilson.co.uk>
To: "Takashi Iwai" <tiwai@suse.de>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Noralf Trønnes" <noralf@tronnes.org>,
"David Airlie" <airlied@linux.ie>
Subject: Re: [PATCH] drm/fb-helper: Don't call dirty callback for untouched clips
Date: Fri, 21 Oct 2016 21:02:27 +0100 [thread overview]
Message-ID: <20161021200227.GU25629@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20161021181903.GN20761@phenom.ffwll.local>
On Fri, Oct 21, 2016 at 08:19:03PM +0200, Daniel Vetter wrote:
> On Fri, Oct 21, 2016 at 01:57:28PM +0100, Chris Wilson wrote:
> > I think of a use for sending an empty clip: where you don't want to
> > push any new pixel data, but you do want to be sure that the pipeline
> > has been flushed.
>
> What exactly should an empty rectangle flush out? It's a bit unclear, but
> for speed I guess drivers should be allowed to make dirty async ...
No idea! I'm just speculating that I can see a use for a dirtyfb barrier
even with an empty cliprect. Empty clips are a useful distinction
elsewhere that I would suggest not forbidding them outright but defining
their behaviour.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2016-10-21 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 14:39 [PATCH] drm/fb-helper: Don't call dirty callback for untouched clips Takashi Iwai
2016-10-20 14:56 ` Ville Syrjälä
2016-10-20 15:00 ` Takashi Iwai
2016-10-21 12:30 ` Daniel Vetter
2016-10-21 12:48 ` Takashi Iwai
2016-10-21 12:57 ` Ville Syrjälä
2016-10-21 12:57 ` Chris Wilson
2016-10-21 18:19 ` Daniel Vetter
2016-10-21 20:02 ` Chris Wilson [this message]
2016-10-22 8:41 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021200227.GU25629@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=tiwai@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox