Re: [PATCH][v12] PM / hibernate: Verify the consistent of e820 memory map by md5 digest

Rafael J. Wysocki
2016-10-24T13:07:29Z

On Sun, Oct 23, 2016 at 10:01 AM, Pavel Machek <pavel@ucw.cz> wrote:
> Hi!
>
>> > 2. Another case is, this patch replies on comparing the e820_saved, but
>> > currently the e820_save might not be strictly the same across
>> > hibernation, even if BIOS has provided consistent e820 map - In
>> > theory mptable might modify the BIOS-provided e820_saved dynamically
>> > in early_reserve_e820_mpc_new, which would allocate a buffer from
>> > E820_RAM, and marks it from E820_RAM to E820_RESERVED).
>> > This is a potential and rare case we need to deal with in OS in
>> > the future.
>> >
>> > Suggested-by: Pavel Machek <pavel@ucw.cz>
>> > Suggested-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
>
> Rafael, can we get this merged? 12 versions is a bit too much..

We can, if there are no more comments.

It actually doesn't matter how many revisions of the patch there are
as long as it isn't ready ...

Thanks,
Rafael