From: Pavel Machek <pavel@ucw.cz>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
sre@kernel.org, pali.rohar@gmail.com,
linux-media@vger.kernel.org, galak@codeaurora.org,
mchehab@osg.samsung.com, linux-kernel@vger.kernel.org
Subject: Re: v4.9-rc1: smiapp divides by zero
Date: Sun, 23 Oct 2016 20:33:34 +0200 [thread overview]
Message-ID: <20161023183334.GA11216@amd> (raw)
In-Reply-To: <20161023140911.GF9460@valkosipuli.retiisi.org.uk>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
Hi!
> > +#define DEBUG
> > +
> > #include <linux/device.h>
> > #include <linux/gcd.h>
> > #include <linux/lcm.h>
> > @@ -457,6 +459,10 @@ int smiapp_pll_calculate(struct device *dev,
> > i = gcd(pll->pll_op_clk_freq_hz, pll->ext_clk_freq_hz);
> > mul = div_u64(pll->pll_op_clk_freq_hz, i);
> > div = pll->ext_clk_freq_hz / i;
> > + if (!mul) {
>
> Something must be very wrong if you get here.
>
> What are the values of pll->pll_op_clk_freq_hz and pll->ext_clk_freq_hz?
> Or... what does dmesg say?
Yep, it was very wrong. I mismerged the stuff, and hwcfg->lanes
initialization was missing. Now it appears to work.
(I have pushed the changes to camera-v4.9 branch).
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-10-23 18:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-11 15:39 [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Ivaylo Dimitrov
2016-06-11 15:39 ` [PATCH v3 1/2] media: Driver for Toshiba et8ek8 5MP sensor Ivaylo Dimitrov
2016-06-18 15:22 ` Pavel Machek
2016-06-18 15:37 ` Pali Rohár
2016-06-18 16:04 ` Pavel Machek
2016-06-18 16:11 ` Pali Rohár
2016-06-20 21:59 ` Sakari Ailus
2016-06-11 15:39 ` [PATCH v3 2/2] media: et8ek8: Add documentation Ivaylo Dimitrov
2016-06-14 22:05 ` Rob Herring
2016-06-15 4:31 ` Sakari Ailus
2016-06-15 18:41 ` Rob Herring
2016-06-15 19:24 ` Ivaylo Dimitrov
2016-06-18 14:36 ` Pavel Machek
2016-10-23 7:33 ` [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Pavel Machek
2016-10-23 10:22 ` v4.9-rc1: smiapp divides by zero Pavel Machek
2016-10-23 10:32 ` Pali Rohár
2016-10-23 10:52 ` Pavel Machek
2016-10-23 14:09 ` Sakari Ailus
2016-10-23 18:33 ` Pavel Machek [this message]
2016-10-23 18:05 ` [PATCH v3 0/2] media: add et8ek8 camera sensor driver and documentation Ivaylo Dimitrov
2016-10-23 18:17 ` Pavel Machek
2016-10-23 18:36 ` Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161023183334.GA11216@amd \
--to=pavel@ucw.cz \
--cc=galak@codeaurora.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=pali.rohar@gmail.com \
--cc=sakari.ailus@iki.fi \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox