From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757072AbcJXDdu (ORCPT ); Sun, 23 Oct 2016 23:33:50 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:34792 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754917AbcJXDdq (ORCPT ); Sun, 23 Oct 2016 23:33:46 -0400 Date: Mon, 24 Oct 2016 09:03:41 +0530 From: Viresh Kumar To: Robert Jarzmik Cc: Daniel Mack , Haojian Zhuang , Rob Herring , Mark Rutland , Rafael Wysocki , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 4/4] cpufreq: pxa: convert to clock API Message-ID: <20161024033341.GA24749@vireshk-i7> References: <1476561450-28407-1-git-send-email-robert.jarzmik@free.fr> <1476561450-28407-5-git-send-email-robert.jarzmik@free.fr> <20161018114025.GD11471@vireshk-i7> <877f902hh6.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877f902hh6.fsf@belgarion.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-10-16, 23:37, Robert Jarzmik wrote: > Viresh Kumar writes: > > > On 15-10-16, 21:57, Robert Jarzmik wrote: > >> As the clock settings have been introduced into the clock pxa drivers, > >> which are now available to change the CPU clock by themselves, remove > >> the clock handling from this driver, and rely on pxa clock drivers. > >> > >> Signed-off-by: Robert Jarzmik > >> --- > >> Since v1: added !OF Kconfig dependency > >> --- > >> drivers/cpufreq/Kconfig.arm | 2 +- > >> drivers/cpufreq/pxa2xx-cpufreq.c | 191 ++++++++------------------------------- > >> 2 files changed, 40 insertions(+), 153 deletions(-) > > > > Acked-by: Viresh Kumar > > Okay, after some more testing, I'd like to remove the !OF for next iteration. > The reason is that I have a usecase where I have a single kernel image with > devictree support (ie CONFIG_OF=y), but with support for both devicetree and > legacy platforms. In this case, a platform such as lubbock can boot : > - with devicetree > - with legacy arch/arm/mach-pxa/lubbock.c > > In this kernel, the !OF Kconfig prevents the legacy version from working, as > pxa2xx-cpufreq is descarded even if it is needed in the legacy version. > > Therefore, I'd like to respin without this !OF. I imagined this case last week as well :) No issues. -- viresh