Re: [PATCH] perf c2c report: Properly check data presence in rb_tree loop

Kim Phillips
2016-10-21T19:23:52Z

On Fri, 21 Oct 2016 02:17:06 +0200
Jiri Olsa <jolsa@redhat.com> wrote:

> On Thu, Oct 20, 2016 at 06:02:24PM -0500, Kim Phillips wrote:
>
> SNIP
>
> > (gdb) bt
> > #0 c2c_browser__update_nr_entries (hb=<optimized out>, hb=<optimized out>) at builtin-c2c.c:2142
> > #1 perf_c2c__hists_browse (hists=0x8b2d90 <c2c+240>) at builtin-c2c.c:2287
> > #2 perf_c2c_display (session=0x205b1a0) at builtin-c2c.c:2316
> > #3 perf_c2c__report (argv=<optimized out>, argc=<optimized out>) at builtin-c2c.c:2621
> > #4 cmd_c2c (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin-c2c.c:2748
> > #5 0x000000000048df61 in run_builtin (p=p@entry=0x8be168 <commands+72>, argc=argc@entry=2, argv=argv@entry=0x7fffffffddb0)
> > at perf.c:358
> > #6 0x00000000004249b6 in handle_internal_command (argv=0x7fffffffddb0, argc=2) at perf.c:420
> > #7 run_argv (argv=0x7fffffffdb40, argcp=0x7fffffffdb4c) at perf.c:466
> > #8 main (argc=2, argv=0x7fffffffddb0) at perf.c:610
> > (gdb)
> >
> > All the above work fine when run under sudo.
>
> ugh, stupid mistake.. attached patch fixes that for me

I see it's been merged here now:

https://git.kernel.org/cgit/linux/kernel/git/acme/linux.git/commit/?h=perf/c2c&id=5a1a99cd2e4e15571a74f65facf05f806d5303fd

and the updated perf-c2c-for-mingo-20161021 works, so thanks all.

Kim