From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nadim Almas <nadim.902@gmail.com>
Cc: aditya.shankar@microchip.com, ganesh.krishna@microchip.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:wilc1000:host_interface: fixed 80 character line limit coding style issue
Date: Mon, 24 Oct 2016 13:58:41 +0300 [thread overview]
Message-ID: <20161024105841.GB4469@mwanda> (raw)
In-Reply-To: <20161021132939.GA5248@gmail.com>
On Fri, Oct 21, 2016 at 06:59:39PM +0530, Nadim Almas wrote:
> Fixed coding style issue
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
> drivers/staging/wilc1000/host_interface.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 0c5dea7..6e6540f 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -497,10 +497,12 @@ static void handle_cfg_param(struct wilc_vif *vif,
> if (cfg_param_attr->flag & POWER_MANAGEMENT) {
> if (cfg_param_attr->power_mgmt_mode < 5) {
> wid_list[i].id = WID_POWER_MANAGEMENT;
> - wid_list[i].val = (s8 *)&cfg_param_attr->power_mgmt_mode;
> + wid_list[i].val = (s8 *)&cfg_param_attr->
> + power_mgmt_mode;
The original was easier to read.
regards,
dan carpenter
prev parent reply other threads:[~2016-10-24 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 13:29 [PATCH] Staging:wilc1000:host_interface: fixed 80 character line limit coding style issue Nadim Almas
2016-10-24 10:58 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024105841.GB4469@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aditya.shankar@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nadim.902@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox