From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrey Vagin <avagin@virtuozzo.com>,
LKML <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@virtuozzo.com>
Subject: [ISSUE] mm: Add a user_ns owner to mm_struct and fix ptrace_may_access
Date: Mon, 24 Oct 2016 13:59:59 +0300 [thread overview]
Message-ID: <20161024105959.GQ1847@uranus.lan> (raw)
Hi Eric! A few days ago we've noticed that our zombie00 test case started
failing: https://ci.openvz.org/job/CRIU/view/All/job/CRIU-linux-next/406/console
---
======================== Run zdtm/static/zombie00 in h =========================
Start test
./zombie00 --pidfile=zombie00.pid --outfile=zombie00.out
Run criu dump
Run criu restore
Send the 15 signal to 30
Wait for zdtm/static/zombie00(30) to die for 0.100000
################ Test zdtm/static/zombie00 FAIL at result check ################
I've narrowed problem down to commit
| From ce99dd5fd5f600f9f4f0d37bb8847c1cb7c6e4fc Mon Sep 17 00:00:00 2001
| From: "Eric W. Biederman" <ebiederm@xmission.com>
| Date: Thu, 13 Oct 2016 21:23:16 -0500
| Subject: [PATCH] mm: Add a user_ns owner to mm_struct and fix
| ptrace_may_access
|
| During exec dumpable is cleared if the file that is being executed is
| not readable by the user executing the file. A bug in
| ptrace_may_access allows reading the file if the executable happens to
| enter into a subordinate user namespace (aka clone(CLONE_NEWUSER),
| unshare(CLONE_NEWUSER), or setns(fd, CLONE_NEWUSER).
and the reason is that the zombie tasks do not have task::mm and in resut
we're obtaining -EPERM when trying to read task->exit_code from /proc/pid/stat.
Looking into commit I suspect when mm = NULL we've to move back the test
ptrace_has_cap(__task_cred(task)->user_ns, mode)?
next reply other threads:[~2016-10-24 11:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 10:59 Cyrill Gorcunov [this message]
2016-10-24 19:00 ` [ISSUE] mm: Add a user_ns owner to mm_struct and fix ptrace_may_access Andrey Vagin
2016-10-24 19:01 ` Eric W. Biederman
2016-10-24 20:29 ` Cyrill Gorcunov
2016-10-24 21:32 ` Kees Cook
2016-10-24 23:11 ` Eric W. Biederman
2016-10-25 9:02 ` Cyrill Gorcunov
2016-10-27 15:54 ` [REVIEW][PATCH v2] mm: Add a user_ns owner to mm_struct and fix ptrace permission checks Eric W. Biederman
2016-10-27 21:27 ` Kees Cook
2016-10-27 21:39 ` Cyrill Gorcunov
2016-10-27 22:34 ` Cyrill Gorcunov
2016-10-28 2:22 ` Eric W. Biederman
2016-10-28 4:45 ` Eric W. Biederman
2016-10-28 7:06 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024105959.GQ1847@uranus.lan \
--to=gorcunov@gmail.com \
--cc=avagin@virtuozzo.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).