From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>,
"Ni, BaoleX" <baolex.ni@intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"acme@kernel.org" <acme@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: hit a KASan bug related to Perf during stress test
Date: Mon, 24 Oct 2016 14:04:11 +0200 [thread overview]
Message-ID: <20161024120411.GA27567@krava> (raw)
In-Reply-To: <20161024112945.GI3157@twins.programming.kicks-ass.net>
On Mon, Oct 24, 2016 at 01:29:45PM +0200, Peter Zijlstra wrote:
> On Mon, Oct 24, 2016 at 01:27:32PM +0200, Peter Zijlstra wrote:
> > On Mon, Oct 24, 2016 at 01:15:27PM +0200, Oleg Nesterov wrote:
> > > How about the trivial fix below?
> > >
> > > Oleg.
> > >
> > > --- x/kernel/events/core.c
> > > +++ x/kernel/events/core.c
> > > @@ -1257,7 +1257,7 @@ static u32 perf_event_pid(struct perf_ev
> > > if (event->parent)
> > > event = event->parent;
> > >
> > > - return task_tgid_nr_ns(p, event->ns);
> > > + return pid_alive(p) ? task_tgid_nr_ns(p, event->ns) : 0;
> > > }
> >
> > Also, now we get a (few) sample(s) with a different pid:tid than prior
> > samples and not matching the sched_switch() events.
> >
> > I can imagine that being somewhat confusing for people/tools.
> >
> > Acme/Jolsa, any idea if that will bugger perf-report?
>
> Hurm, then again, I imagine that after unhash_process the PID/TID could
> be instantly re-used and then we're still confused.
sounds bad.. I haven't checked the related pid_alive code,
but shouldn't we already get the EXIT event in this case?
jirka
next prev parent reply other threads:[~2016-10-24 12:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <318B87A793BE164187D8851D6CE09D64371C8811@shsmsx102.ccr.corp.intel.com>
2016-10-24 9:53 ` hit a KASan bug related to Perf during stress test Peter Zijlstra
2016-10-24 11:15 ` Oleg Nesterov
2016-10-24 11:24 ` Peter Zijlstra
2016-10-24 12:02 ` Oleg Nesterov
2016-10-24 12:10 ` Oleg Nesterov
2016-10-24 12:22 ` Peter Zijlstra
2016-10-24 12:29 ` Oleg Nesterov
2016-10-24 12:38 ` Peter Zijlstra
2016-10-24 13:25 ` Oleg Nesterov
2016-10-24 13:40 ` Oleg Nesterov
2016-10-24 14:17 ` Peter Zijlstra
2016-10-24 14:36 ` Peter Zijlstra
2016-10-24 15:39 ` Oleg Nesterov
2016-10-24 15:53 ` Oleg Nesterov
2016-10-25 6:55 ` Ni, BaoleX
2016-10-25 9:28 ` Peter Zijlstra
2016-10-25 14:41 ` Oleg Nesterov
2016-10-26 9:03 ` Peter Zijlstra
2016-10-26 16:10 ` Oleg Nesterov
2016-10-24 12:19 ` Peter Zijlstra
2016-10-24 11:27 ` Peter Zijlstra
2016-10-24 11:29 ` Peter Zijlstra
2016-10-24 12:04 ` Jiri Olsa [this message]
2016-10-24 12:12 ` Peter Zijlstra
2016-10-24 12:11 ` Peter Zijlstra
2016-10-24 12:21 ` Oleg Nesterov
2016-10-24 12:27 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024120411.GA27567@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox