From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S941067AbcJXOJz (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Oct 2016 10:09:55 -0400
Received: from mail-pf0-f172.google.com ([209.85.192.172]:36600 "EHLO
        mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S936532AbcJXOJv (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2016 10:09:51 -0400
Date: Mon, 24 Oct 2016 23:08:45 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Petr Mladek <pmladek@suse.cz>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: linux.git: printk() problem
Message-ID: <20161024140845.GA626@swordfish>
References: <201610122230.DID43237.FSOHFFQOJOtVML@I-love.SAKURA.ne.jp>
 <CA+55aFwLLxVKZcN4qm0GH0sHk70xRE8e4s8_ma6WYafao85Rfw@mail.gmail.com>
 <CAMuHMdXUqOhv37mTvX+ic45VsgvM1g3=McWAa1WCeVYH+KohCw@mail.gmail.com>
 <CA+55aFw1Z95Lfefr1PfZW17qj9zjv+-bZ-oPESTNk+tbAEVrhQ@mail.gmail.com>
 <1477249607.3561.2.camel@perches.com>
 <CA+55aFwOBR6z55r2abAT_TuYTHfyuc8f75B2+Z7+Lhr9fzSZRA@mail.gmail.com>
 <CA+55aFzm6RpkaiDzS_q3J=4_hykCCgAZLjEf5nffgSZjUpQ17A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+55aFzm6RpkaiDzS_q3J=4_hykCCgAZLjEf5nffgSZjUpQ17A@mail.gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello,

thanks for Cc-ing.

On (10/23/16 12:46), Linus Torvalds wrote:
> +static void deferred_cont_flush(void)
> +{
> +	static DEFINE_TIMER(timer, flush_timer, 0, 0);
> +
> +	if (!cont.len)
>  		return;
> +	mod_timer(&timer, jiffies + HZ/10);
>  }

[..]

> @@ -2360,6 +2285,8 @@ void console_unlock(void)
>  		return;
>  	}
>  
> +	deferred_cont_flush();
> +

is mod_timer() safe enough to rely on/call from
	panic()->console_flush_on_panic()->console_unlock() ?

shouldn't deferred_cont_flush() be called every time we jump
to `again' label in console_unlock()?

timer has debug object support, which probably can printk(), but
that shouldn't cause any troubles, I suppose.

	-ss