public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nadim Almas <nadim.902@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:wlan-ng:hfa384x: fixed 80 character line limit coding style issue
Date: Tue, 25 Oct 2016 10:48:43 +0200	[thread overview]
Message-ID: <20161025084843.GA5727@kroah.com> (raw)
In-Reply-To: <20161021124232.GA4398@gmail.com>

On Fri, Oct 21, 2016 at 06:12:32PM +0530, Nadim Almas wrote:
> Fixed coding style issue
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 6337b1d..cca2652 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1349,7 +1349,9 @@ struct hfa384x {
>  						  * interface
>  						  */
>  
> -	struct hfa384x_caplevel cap_act_sta_mfi; /* sta f/w to modem interface */
> +	struct hfa384x_caplevel cap_act_sta_mfi; /*
> +						  * sta f/w to modem interface
> +						  */
>  
>  	struct hfa384x_caplevel cap_act_ap_cfi;	/*
>  						 * ap f/w to controller
> @@ -1371,7 +1373,9 @@ struct hfa384x {
>  
>  	struct hfa384x_inf_frame *scanresults;
>  
> -	struct prism2sta_authlist authlist;	/* Authenticated station list. */
> +	struct prism2sta_authlist authlist;	/*
> +						 * Authenticated station list
> +						 */

These changes really don't make things more readable, do they?  Put the
comment above the variable if you really care, or just don't worry about
the 1 or 2 characters over the line-length limit here.

thanks,

greg k-h

      reply	other threads:[~2016-10-25  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21 12:42 [PATCH] Staging:wlan-ng:hfa384x: fixed 80 character line limit coding style issue Nadim Almas
2016-10-25  8:48 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161025084843.GA5727@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadim.902@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox