* [PATCH] [net-next] net: ip, diag: include net/inet_sock.h
@ 2016-10-25 15:53 Arnd Bergmann
2016-10-25 16:06 ` Cyrill Gorcunov
2016-10-29 18:53 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-10-25 15:53 UTC (permalink / raw)
To: David S. Miller
Cc: Arnd Bergmann, Alexey Kuznetsov, James Morris, Hideaki YOSHIFUJI,
Patrick McHardy, Cyrill Gorcunov, netdev, linux-kernel
The newly added raw_diag.c fails to build in some configurations
unless we include this header:
In file included from net/ipv4/raw_diag.c:6:0:
include/net/raw.h:71:21: error: field 'inet' has incomplete type
net/ipv4/raw_diag.c: In function 'raw_diag_dump':
net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk'
Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
net/ipv4/raw_diag.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/raw_diag.c b/net/ipv4/raw_diag.c
index ef3bea061b75..be930908bcf9 100644
--- a/net/ipv4/raw_diag.c
+++ b/net/ipv4/raw_diag.c
@@ -3,6 +3,7 @@
#include <linux/inet_diag.h>
#include <linux/sock_diag.h>
+#include <net/inet_sock.h>
#include <net/raw.h>
#include <net/rawv6.h>
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h
2016-10-25 15:53 [PATCH] [net-next] net: ip, diag: include net/inet_sock.h Arnd Bergmann
@ 2016-10-25 16:06 ` Cyrill Gorcunov
2016-10-29 18:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cyrill Gorcunov @ 2016-10-25 16:06 UTC (permalink / raw)
To: Arnd Bergmann
Cc: David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, linux-kernel
On Tue, Oct 25, 2016 at 05:53:22PM +0200, Arnd Bergmann wrote:
> The newly added raw_diag.c fails to build in some configurations
> unless we include this header:
>
> In file included from net/ipv4/raw_diag.c:6:0:
> include/net/raw.h:71:21: error: field 'inet' has incomplete type
> net/ipv4/raw_diag.c: In function 'raw_diag_dump':
> net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk'
>
> Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thank you! And sorry for this, it didn't trigger on my testing.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h
2016-10-25 15:53 [PATCH] [net-next] net: ip, diag: include net/inet_sock.h Arnd Bergmann
2016-10-25 16:06 ` Cyrill Gorcunov
@ 2016-10-29 18:53 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-10-29 18:53 UTC (permalink / raw)
To: arnd; +Cc: kuznet, jmorris, yoshfuji, kaber, gorcunov, netdev, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 25 Oct 2016 17:53:22 +0200
> The newly added raw_diag.c fails to build in some configurations
> unless we include this header:
>
> In file included from net/ipv4/raw_diag.c:6:0:
> include/net/raw.h:71:21: error: field 'inet' has incomplete type
> net/ipv4/raw_diag.c: In function 'raw_diag_dump':
> net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk'
>
> Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks Arnd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-29 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-25 15:53 [PATCH] [net-next] net: ip, diag: include net/inet_sock.h Arnd Bergmann
2016-10-25 16:06 ` Cyrill Gorcunov
2016-10-29 18:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox