From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759300AbcJYQGI (ORCPT ); Tue, 25 Oct 2016 12:06:08 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35686 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759131AbcJYQGF (ORCPT ); Tue, 25 Oct 2016 12:06:05 -0400 Date: Tue, 25 Oct 2016 19:06:02 +0300 From: Cyrill Gorcunov To: Arnd Bergmann Cc: "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] net: ip, diag: include net/inet_sock.h Message-ID: <20161025160602.GZ1847@uranus.lan> References: <20161025155339.9892-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161025155339.9892-1-arnd@arndb.de> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2016 at 05:53:22PM +0200, Arnd Bergmann wrote: > The newly added raw_diag.c fails to build in some configurations > unless we include this header: > > In file included from net/ipv4/raw_diag.c:6:0: > include/net/raw.h:71:21: error: field 'inet' has incomplete type > net/ipv4/raw_diag.c: In function 'raw_diag_dump': > net/ipv4/raw_diag.c:166:29: error: implicit declaration of function 'inet_sk' > > Fixes: 432490f9d455 ("net: ip, diag -- Add diag interface for raw sockets") > Signed-off-by: Arnd Bergmann Thank you! And sorry for this, it didn't trigger on my testing.