From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Jin, Yao" <yao.jin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>,
Nilay Vaish <nilayvaish@gmail.com>, Jiri Olsa <jolsa@kernel.org>,
Linux Kernel list <Linux-kernel@vger.kernel.org>,
kan.liang@intel.com
Subject: Re: [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain
Date: Tue, 25 Oct 2016 15:11:05 -0300 [thread overview]
Message-ID: <20161025181105.GH4543@kernel.org> (raw)
In-Reply-To: <747ba5dc-8015-7634-eb1c-94f82ebb75b1@linux.intel.com>
Em Fri, Oct 21, 2016 at 08:23:41AM +0800, Jin, Yao escreveu:
> Hi Andi, Hi Nilay,
>
> Thanks so much for your comments!
>
> I will upgrade the patch to just display the count for abort.
Ok, waiting for that then,
- Arnaldo
> Thanks
>
> Jin Yao
>
> On 10/21/2016 2:20 AM, Andi Kleen wrote:
> > > OK, I am more confused now. Are you predicting some quantity related
> > > to transactions? Why would you divide abort count by branch count?
> > > Further, I just looked at patch 6/6. It has the following text:
> > >
> > > + Also show with some branch flags that can be:
> > > + - Predicted: display the average percentage of predicated branches.
> > > + (predicated number / total number)
> > > + - Abort: display the average percentage of abort branches.
> > > + (abort number /total number)
> > > + - Cycles: cycles in basic block.
> > >
> > >
> > > I think there is inconsistency between what you are suggesting and
> > > what the patch has.
> > An abort is an unique branch. But yes there is no total number,
> > so the formula will always be 100%. So yes would probably be
> > better to just display a count for abort.
> >
> > -Andi
next prev parent reply other threads:[~2016-10-25 18:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 22:01 [PATCH v2 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Jin Yao
2016-10-19 22:01 ` [PATCH v2 1/6] perf report: Add branch flag to callchain cursor node Jin Yao
2016-10-19 22:01 ` [PATCH v2 2/6] perf report: Caculate and return the branch counting in callchain Jin Yao
2016-10-20 16:41 ` Nilay Vaish
2016-10-20 16:48 ` Andi Kleen
2016-10-20 17:06 ` Nilay Vaish
2016-10-20 18:20 ` Andi Kleen
2016-10-21 0:23 ` Jin, Yao
2016-10-25 18:11 ` Arnaldo Carvalho de Melo [this message]
2016-10-19 22:01 ` [PATCH v2 3/6] perf report: Create a symbol_conf flag for showing branch flag counting Jin Yao
2016-10-19 22:01 ` [PATCH v2 4/6] perf report: Show branch info in callchain entry for stdio mode Jin Yao
2016-10-19 22:01 ` [PATCH v2 5/6] perf report: Show branch info in callchain entry for browser mode Jin Yao
2016-10-19 22:01 ` [PATCH v2 6/6] perf report: Display columns Predicted/Abort/Cycles in --branch-history Jin Yao
2016-10-23 14:10 ` [PATCH v2 0/6] perf report: Show branch flags/cycles in --branch-history callgraph view Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025181105.GH4543@kernel.org \
--to=acme@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=nilayvaish@gmail.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox