From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/5] selftests: ftrace: Fix test cases to enable tracing
Date: Tue, 25 Oct 2016 18:51:26 +0900 [thread overview]
Message-ID: <20161025185126.c0cf722d1d1d140bfb2f7ee0@kernel.org> (raw)
In-Reply-To: <20161024155027.5dd9674a@gandalf.local.home>
Hi Steve,
On Mon, 24 Oct 2016 15:50:27 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 19 Oct 2016 13:53:46 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Fix some test cases to enable tracing before starting
> > trace test. This can avoid false-positive failure when
> > previous testcase fails while disabling tracing.
>
> I wonder if this would be better to do the enabling from the ftracetest
> script instead. Then the tests would need to worry about it.
Hm, sounds reasonable. Also some other options should be reset for
avoiding unexpected failure. I'll try that.
Thanks!
>
> -- Steve
>
>
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > .../selftests/ftrace/test.d/event/event-enable.tc | 1 +
> > .../selftests/ftrace/test.d/event/event-pid.tc | 1 +
> > .../ftrace/test.d/event/subsystem-enable.tc | 1 +
> > .../ftrace/test.d/event/toplevel-enable.tc | 1 +
> > .../ftrace/test.d/ftrace/func_profiler.tc | 1 +
> > .../ftrace/test.d/kprobe/kprobe_ftrace.tc | 1 +
> > 6 files changed, 6 insertions(+)
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > index 87eb9d6..ee7ea0a 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc
> > @@ -23,6 +23,7 @@ fi
> >
> > reset_tracer
> > do_reset
> > +enable_tracing
> >
> > echo 'sched:sched_switch' > set_event
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-pid.tc b/tools/testing/selftests/ftrace/test.d/event/event-pid.tc
> > index d4ab27b..1477e5e 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/event-pid.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/event-pid.tc
> > @@ -30,6 +30,7 @@ fi
> >
> > reset_tracer
> > do_reset
> > +enable_tracing
> >
> > echo 1 > events/sched/sched_switch/enable
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> > index ced27ef..f4a64f9 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc
> > @@ -23,6 +23,7 @@ fi
> >
> > reset_tracer
> > do_reset
> > +enable_tracing
> >
> > echo 'sched:*' > set_event
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > index 0bb5df3..037a82e 100644
> > --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc
> > @@ -23,6 +23,7 @@ fi
> >
> > reset_tracer
> > do_reset
> > +enable_tracing
> >
> > echo '*:*' > set_event
> >
> > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> > index 7808336..d10d6e0 100644
> > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc
> > @@ -36,6 +36,7 @@ fail() { # mesg
> >
> > echo "Testing function tracer with profiler:"
> > echo "enable function tracer"
> > +enable_tracing
> > echo function > current_tracer
> > echo "enable profiler"
> > echo 1 > function_profile_enabled
> > diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
> > index d6f2f49..bdbd385 100644
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_ftrace.tc
> > @@ -10,6 +10,7 @@ echo _do_fork > set_ftrace_filter
> > echo 0 > events/enable
> > echo > kprobe_events
> > echo 'p:testprobe _do_fork' > kprobe_events
> > +enable_tracing
> >
> > # kprobe on / ftrace off
> > echo 1 > events/kprobes/testprobe/enable
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2016-10-25 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 4:53 [PATCH 0/5] ftrace: selftests: Add full glob matching and update ftracetest Masami Hiramatsu
2016-10-19 4:53 ` [PATCH 1/5] ftrace: Support full glob matching Masami Hiramatsu
2016-10-19 13:20 ` Steven Rostedt
2016-10-20 2:07 ` Masami Hiramatsu
2016-10-20 13:43 ` Steven Rostedt
2016-10-21 16:43 ` Masami Hiramatsu
2016-10-19 4:53 ` [PATCH 2/5] selftests: ftrace: Fix test cases to enable tracing Masami Hiramatsu
2016-10-24 19:50 ` Steven Rostedt
2016-10-25 9:51 ` Masami Hiramatsu [this message]
2016-10-19 4:53 ` [PATCH 3/5] selftests: ftrace: Introduce TMPDIR for temporary files Masami Hiramatsu
2016-10-19 4:54 ` [PATCH 4/5] selftests: ftrace: Add a testcase for function filter glob match Masami Hiramatsu
2016-10-19 4:54 ` [PATCH 5/5] selftests: ftrace: Add a testcase for types of kprobe event Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025185126.c0cf722d1d1d140bfb2f7ee0@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox