From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
computersforpeace@gmail.com
Subject: complete_all and "forever" completions
Date: Tue, 25 Oct 2016 15:30:54 -0700 [thread overview]
Message-ID: <20161025223054.GA22917@dtor-ws> (raw)
Hi,
Reading Documentation/scheduler/completion.txt, complete_all() is
supposed to be usable with "forever" completions, i.e. when we have an
action that happens once and stays "done" for the rest of lifetime of an
object, no matter how many times we check for "doneness". However the
implementation for complete_all() simply sets the counter to be greater
or equal UINT_MAX/2 and do_wait_for_common() happily decreases it on
every call.
Is it simply an artefact of [older] implementation where we do not
expect to make that many calls to wait_for_completion*() so that
completion that is signalled with ocmplete_all() is practically stays
signalled forever? Or do we need something like this in
do_wait_for_common():
if (x->done < UINT_MAX/2)
x->done--;
Thanks.
--
Dmitry
next reply other threads:[~2016-10-25 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 22:30 Dmitry Torokhov [this message]
2016-10-26 8:45 ` complete_all and "forever" completions Peter Zijlstra
2016-10-26 9:15 ` Nicholas Mc Guire
2016-10-27 9:51 ` Daniel Wagner
2016-10-26 12:10 ` Dmitry Torokhov
2016-10-26 15:42 ` Peter Zijlstra
2016-10-26 15:46 ` Peter Zijlstra
2016-10-26 17:12 ` Nicholas Mc Guire
2016-10-26 17:20 ` Dmitry Torokhov
2016-10-26 18:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025223054.GA22917@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox