Re: [PATCH V2 7/8] PM / OPP: Allow platform specific custom opp_set_rate() callbacks

Stephen Boyd
2016-10-25T19:01:18Z

On 10/20, Viresh Kumar wrote:
> The generic opp_set_rate() handler isn't sufficient for platforms with
> complex DVFS. For example, some TI platforms have multiple regulators
> for a CPU device. The order in which various supplies need to be
> programmed is only known to the platform code and its best to leave it
> to it.
>
> This patch implements APIs to register platform specific opp_set_rate()
> callback.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---

Overall it looks ok, but I'd prefer set_opp instead of set_rate.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project