linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, "Mark Brown" <broonie@kernel.org>,
	"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
	"Charles Keepax" <ckeepax@opensource.wolfsonmicro.com>,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] mfd: wm8994-core: don't split lines unnecessarily
Date: Wed, 26 Oct 2016 13:20:31 +0100	[thread overview]
Message-ID: <20161026122031.GV8574@dell> (raw)
In-Reply-To: <7d68a9e5dd338081342dd8b06310c2f3e61fccc0.1473996370.git.viresh.kumar@linaro.org>

On Fri, 16 Sep 2016, Viresh Kumar wrote:

> These can fit in a single line (80 columns), don't split lines
> unnecessarily.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> 
> ---
> V1->V2: New patch
> ---
>  drivers/mfd/wm8994-core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c
> index 7eec619a6023..1990b2c90732 100644
> --- a/drivers/mfd/wm8994-core.c
> +++ b/drivers/mfd/wm8994-core.c
> @@ -401,8 +401,7 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq)
>  		goto err;
>  	}
>  
> -	ret = regulator_bulk_enable(wm8994->num_supplies,
> -				    wm8994->supplies);
> +	ret = regulator_bulk_enable(wm8994->num_supplies, wm8994->supplies);
>  	if (ret != 0) {
>  		dev_err(wm8994->dev, "Failed to enable supplies: %d\n", ret);
>  		goto err;
> @@ -606,8 +605,7 @@ static void wm8994_device_exit(struct wm8994 *wm8994)
>  	pm_runtime_disable(wm8994->dev);
>  	mfd_remove_devices(wm8994->dev);
>  	wm8994_irq_exit(wm8994);
> -	regulator_bulk_disable(wm8994->num_supplies,
> -			       wm8994->supplies);
> +	regulator_bulk_disable(wm8994->num_supplies, wm8994->supplies);
>  }
>  
>  static const struct of_device_id wm8994_of_match[] = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

      parent reply	other threads:[~2016-10-26 12:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  3:26 [PATCH V2 1/3] mfd: wm8994-core: don't split lines unnecessarily Viresh Kumar
2016-09-16  3:26 ` [PATCH V2 2/3] mfd: wm8994-core: disable regulators before removing them Viresh Kumar
2016-10-26 12:22   ` Lee Jones
2016-09-16  3:27 ` [PATCH V2 3/3] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar
2016-09-16  7:38   ` Charles Keepax
2016-10-26 12:22   ` Lee Jones
2016-10-26 12:24     ` Lee Jones
2016-09-16  7:37 ` [PATCH V2 1/3] mfd: wm8994-core: don't split lines unnecessarily Charles Keepax
2016-10-03 10:56 ` Viresh Kumar
2016-10-04 14:41   ` Lee Jones
2016-10-05  0:39     ` Viresh Kumar
2016-10-05  8:49       ` Lee Jones
2016-10-05  8:55         ` Viresh Kumar
2016-10-05  9:10           ` Lee Jones
2016-10-26 12:20 ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161026122031.GV8574@dell \
    --to=lee.jones@linaro.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=k.kozlowski@samsung.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).