From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755149AbcJZMUe (ORCPT ); Wed, 26 Oct 2016 08:20:34 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38833 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752691AbcJZMUc (ORCPT ); Wed, 26 Oct 2016 08:20:32 -0400 Date: Wed, 26 Oct 2016 13:22:58 +0100 From: Lee Jones To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, Mark Brown , Krzysztof =?utf-8?Q?Koz=C5=82owski?= , Charles Keepax , patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/3] mfd: wm8994-core: disable regulators before removing them Message-ID: <20161026122258.GX8574@dell> References: <7d68a9e5dd338081342dd8b06310c2f3e61fccc0.1473996370.git.viresh.kumar@linaro.org> <1ea4eed2967fd566fe0aa4a9f7a4d55083618445.1473996370.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1ea4eed2967fd566fe0aa4a9f7a4d55083618445.1473996370.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Sep 2016, Viresh Kumar wrote: > The order in which resources were freed in wm8994_device_exit() isn't > correct. The regulators are removed before they are disabled. > > Fix it by reordering code a bit, which makes it exact opposite of > wm8994_device_init() as well. > > Signed-off-by: Viresh Kumar > Acked-by: Charles Keepax > > --- > V1->V2: > - Added Ack from Charles. > --- > drivers/mfd/wm8994-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > diff --git a/drivers/mfd/wm8994-core.c b/drivers/mfd/wm8994-core.c > index 1990b2c90732..95e6bc55adbb 100644 > --- a/drivers/mfd/wm8994-core.c > +++ b/drivers/mfd/wm8994-core.c > @@ -603,9 +603,9 @@ static int wm8994_device_init(struct wm8994 *wm8994, int irq) > static void wm8994_device_exit(struct wm8994 *wm8994) > { > pm_runtime_disable(wm8994->dev); > - mfd_remove_devices(wm8994->dev); > wm8994_irq_exit(wm8994); > regulator_bulk_disable(wm8994->num_supplies, wm8994->supplies); > + mfd_remove_devices(wm8994->dev); > } > > static const struct of_device_id wm8994_of_match[] = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog