From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966980AbcJZMpN (ORCPT ); Wed, 26 Oct 2016 08:45:13 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35680 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030207AbcJZMpK (ORCPT ); Wed, 26 Oct 2016 08:45:10 -0400 Date: Wed, 26 Oct 2016 13:40:37 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mfd: hi655x-pmic: Fix module autoload when registered via OF Message-ID: <20161026124037.GF11267@dell> References: <1476459651-3897-1-git-send-email-javier@osg.samsung.com> <1476459651-3897-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476459651-3897-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Oct 2016, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias > > After this patch: > > $ modinfo drivers/mfd/hi655x-pmic.ko | grep alias > alias: of:N*T*Chisilicon,hi655x-pmicC* > alias: of:N*T*Chisilicon,hi655x-pmic > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/hi655x-pmic.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c > index 0fc62995695b..ba706adee38b 100644 > --- a/drivers/mfd/hi655x-pmic.c > +++ b/drivers/mfd/hi655x-pmic.c > @@ -169,6 +169,7 @@ static const struct of_device_id hi655x_pmic_match[] = { > { .compatible = "hisilicon,hi655x-pmic", }, > {}, > }; > +MODULE_DEVICE_TABLE(of, hi655x_pmic_match); > > static struct platform_driver hi655x_pmic_driver = { > .driver = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog