From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942620AbcJZMud (ORCPT ); Wed, 26 Oct 2016 08:50:33 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37917 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942366AbcJZMt7 (ORCPT ); Wed, 26 Oct 2016 08:49:59 -0400 Date: Wed, 26 Oct 2016 13:51:51 +0100 From: Lee Jones To: tthayer@opensource.altera.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, dinguyen@opensource.altera.com, inux@armlinux.org.uk, arnd@arndb.de, gregkh@linuxfoundation.org, davem@davemloft.net, geert@linux-m68k.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add Altera Arria10 SR Monitor Message-ID: <20161026125151.GK11267@dell> References: <1476394329-31696-1-git-send-email-tthayer@opensource.altera.com> <1476394329-31696-2-git-send-email-tthayer@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1476394329-31696-2-git-send-email-tthayer@opensource.altera.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Oct 2016, tthayer@opensource.altera.com wrote: > From: Thor Thayer > > Add the Arria10 DevKit System Resource Chip register and state > monitoring module to the MFD. > > Signed-off-by: Thor Thayer > --- > Note: This needs to be applied to the bindings document that > was Acked & Applied but didn't reach the for-next branch. > See https://patchwork.ozlabs.org/patch/629397/ > --- > --- > .../devicetree/bindings/mfd/altera-a10sr.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > index ea151f2..0787ec6 100644 > --- a/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > +++ b/Documentation/devicetree/bindings/mfd/altera-a10sr.txt > @@ -18,6 +18,7 @@ The A10SR consists of these sub-devices: > Device Description > ------ ---------- > a10sr_gpio GPIO Controller > +a10sr_monitor Register and State Monitoring > > Arria10 GPIO > Required Properties: > @@ -27,6 +28,10 @@ Required Properties: > the second cell is used to specify flags. > See ../gpio/gpio.txt for more information. > > +Arria10 Register and State Monitor > +Required Properties: > +- compatible : Should be "altr,a10sr-mon" Why not "-monitor"? > Example: > > resource-manager@0 { > @@ -43,4 +48,8 @@ Example: > gpio-controller; > #gpio-cells = <2>; > }; > + > + a10sr_monitor { > + compatible = "altr,a10sr-mon"; > + }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog