From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934354AbcJZOTv (ORCPT ); Wed, 26 Oct 2016 10:19:51 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:38441 "EHLO mail-lf0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753455AbcJZOTs (ORCPT ); Wed, 26 Oct 2016 10:19:48 -0400 Date: Wed, 26 Oct 2016 15:22:14 +0100 From: Lee Jones To: Daniel Hung-yu Wu Cc: Samuel Ortiz , hywu@chromium.org, ejcaruso@chromium.org, drinkcat@chromium.org, kyan@chromium.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works Message-ID: <20161026142214.GK13127@dell> References: <20161024075257.GA5303@google.com> <20161026140403.GG13127@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161026140403.GG13127@dell> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 26 Oct 2016, Lee Jones wrote: > On Mon, 24 Oct 2016, Daniel Hung-yu Wu wrote: > > > This patch applies on top of "mfd: cros_ec: Add EC console read structures > > definitions" (https://patchwork.kernel.org/patch/9294887/). > > > > This patch is currently against a linux 3.18 kernel. > > > > Reboot or shutdown during delayed works could corrupt communication with EC, > > and certain I2C controller may not be able to recover from the error state. > > A shutdown function is registered to clear delayed works or wait for them to > > finish. > > > > Signed-off-by: Daniel Hung-yu Wu > > --- > > drivers/mfd/cros_ec_dev.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > Applied, thanks. Ah, I thought you'd at least ported it to Mainline! You need to do that before posting patches. > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c > > index 8618a7c..3e548f1 100644 > > --- a/drivers/mfd/cros_ec_dev.c > > +++ b/drivers/mfd/cros_ec_dev.c > > @@ -613,6 +613,14 @@ static int ec_device_remove(struct platform_device *pdev) > > return 0; > > } > > > > +static void ec_device_shutdown(struct platform_device *pdev) > > +{ > > + struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev); > > + > > + /* Be sure to clear up debugfs delayed works */ > > + cros_ec_debugfs_remove(ec); > > +} > > + > > static int ec_device_suspend(struct device *dev) > > { > > struct cros_ec_dev *ec = dev_get_drvdata(dev); > > @@ -656,6 +664,7 @@ static struct platform_driver cros_ec_dev_driver = { > > }, > > .probe = ec_device_probe, > > .remove = ec_device_remove, > > + .shutdown = ec_device_shutdown, > > }; > > > > static int __init cros_ec_dev_init(void) > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog