From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
yang.zhang.wz@gmail.com, feng.wu@intel.com, mst@redhat.com
Subject: Re: [PATCH 4/5] KVM: x86: remove unnecessary sync_pir_to_irr
Date: Wed, 26 Oct 2016 22:28:38 +0200 [thread overview]
Message-ID: <20161026202837.GF4212@potion> (raw)
In-Reply-To: <1476469291-5039-5-git-send-email-pbonzini@redhat.com>
2016-10-14 20:21+0200, Paolo Bonzini:
> Synchronizing PIR to IRR is not needed in most callers of
> apic_find_highest_irr. Move it to the one place that matters,
> interrupt acknowledgement.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> @@ -1973,6 +1971,9 @@ int kvm_apic_has_interrupt(struct kvm_vcpu *vcpu)
> return -1;
>
> apic_update_ppr(apic);
> +
> + if (apic->vcpu->arch.apicv_active)
> + kvm_x86_ops->sync_pir_to_irr(apic->vcpu);
Btw. do all callers of kvm_apic_has_interrupt() need it?
Thanks.
> highest_irr = apic_find_highest_irr(apic);
> if ((highest_irr == -1) ||
> ((highest_irr & 0xF0) <= kvm_lapic_get_reg(apic, APIC_PROCPRI)))
next prev parent reply other threads:[~2016-10-26 20:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 18:21 [PATCH 0/5] KVM: x86: cleanup and minimal speedup for APICv Paolo Bonzini
2016-10-14 18:21 ` [PATCH 1/5] KVM: x86: avoid atomic operations on APICv vmentry Paolo Bonzini
2016-10-14 18:50 ` Nadav Amit
2016-10-14 18:56 ` Paolo Bonzini
2016-10-14 19:44 ` Nadav Amit
2016-10-15 7:47 ` Paolo Bonzini
2016-10-16 2:29 ` Michael S. Tsirkin
2016-10-19 11:45 ` Paul E. McKenney
2016-10-26 21:50 ` Michael S. Tsirkin
2016-10-16 3:21 ` Michael S. Tsirkin
2016-10-17 11:07 ` Paolo Bonzini
2016-10-26 19:53 ` Radim Krčmář
2016-10-26 21:42 ` Michael S. Tsirkin
2016-10-27 16:44 ` Radim Krčmář
2016-10-27 16:51 ` Michael S. Tsirkin
2016-10-27 17:06 ` Radim Krčmář
2016-10-28 9:39 ` Paolo Bonzini
2016-10-28 22:04 ` Michael S. Tsirkin
2016-10-14 18:21 ` [PATCH 2/5] KVM: x86: do not scan IRR twice " Paolo Bonzini
2016-10-18 6:04 ` Wanpeng Li
2016-10-26 19:59 ` Radim Krčmář
2016-11-03 13:30 ` Paolo Bonzini
2016-11-03 13:53 ` Michael S. Tsirkin
2016-11-03 16:01 ` Paolo Bonzini
2016-11-03 15:03 ` Radim Krčmář
2016-11-03 16:00 ` Paolo Bonzini
2016-11-03 18:07 ` Radim Krčmář
2016-11-03 18:18 ` Paolo Bonzini
2016-11-03 18:29 ` Radim Krčmář
2016-11-03 20:16 ` Radim Krčmář
2016-11-04 9:38 ` Paolo Bonzini
2016-10-14 18:21 ` [PATCH 3/5] KVM: x86: do not use KVM_REQ_EVENT for APICv interrupt injection Paolo Bonzini
2016-10-26 20:05 ` Radim Krčmář
2016-10-14 18:21 ` [PATCH 4/5] KVM: x86: remove unnecessary sync_pir_to_irr Paolo Bonzini
2016-10-26 20:28 ` Radim Krčmář [this message]
2016-10-14 18:21 ` [PATCH 5/5] KVM: vmx: clear pending interrupts on KVM_SET_LAPIC Paolo Bonzini
2016-10-26 20:08 ` Radim Krčmář
2016-10-26 21:52 ` [PATCH 0/5] KVM: x86: cleanup and minimal speedup for APICv Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026202837.GF4212@potion \
--to=rkrcmar@redhat.com \
--cc=feng.wu@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).