From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935056AbcJ0CLY (ORCPT ); Wed, 26 Oct 2016 22:11:24 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:45888 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932707AbcJ0CLS (ORCPT ); Wed, 26 Oct 2016 22:11:18 -0400 Date: Thu, 27 Oct 2016 03:11:11 +0100 From: Al Viro To: Ian Kent Cc: Andrew Morton , autofs mailing list , Kernel Mailing List , "Eric W. Biederman" , linux-fsdevel , Omar Sandoval Subject: Re: [PATCH 1/8] vfs - change d_manage() to take a struct path Message-ID: <20161027021111.GI19539@ZenIV.linux.org.uk> References: <20161011053352.27645.83962.stgit@pluto.themaw.net> <20161019124031.94a44fbdd0970989f05d1893@linux-foundation.org> <1477006776.3207.14.camel@themaw.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477006776.3207.14.camel@themaw.net> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2016 at 07:39:36AM +0800, Ian Kent wrote: > Maybe Al has been too busy to comment, he has been on the Cc from the start. That's... a very mild version of what's been going on. Let's just say that the last few weeks had been really interesting. Not that the shit has settled, but there was some slackening in the shitstorm last few days. Unlikely to last, I'm afraid, but... > Hopefully this email will prompt a review, Al? Aside of the Eric's note re constifying struct path (strongly seconded), I'm not sure if expiration-related side of that is correct. OTOH, since the expiration happens from userland... How much testing did it get? I've several test setups involving autofs, but they are nowhere near exhaustive and I don't have good enough feel of the codebase to slap together something with decent coverage...