linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: Laura Abbott <labbott@redhat.com>,
	Andy Lutomirski <luto@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: printk badness with VMAP_STACK
Date: Thu, 27 Oct 2016 20:58:57 +0900	[thread overview]
Message-ID: <20161027115857.GA410@swordfish> (raw)
In-Reply-To: <20161027091937.GU23809@pathway.suse.cz>

Hello,

thanks for Cc-ing.

On (10/27/16 11:19), Petr Mladek wrote:
[..]
> Yeah, logbuf_lock is taken on many locations but logbuf_cpu is set
> only in vprintk_emit(). It means that the other locations, including
> console_unlock() are not protected against this type of recursion.
> 
> There is actually a whole bunch of possible printk-related deadlocks.
> There are several approaches how to handle some of them, for example:
> 
>  + printk_save(), see
>    https://lkml.kernel.org/r/20161018154045.7364-1-sergey.senozhatsky@gmail.com
> 
>  + async printk, see
>    https://lkml.kernel.org/r/1459789048-1337-1-git-send-email-sergey.senozhatsky@gmail.com
> 
>  + early console, see
>    https://lkml.kernel.org/r/20161018170830.405990950@infradead.org
> 
> 
> The more we try to fix them, the more problems we see. Sergey probably
> has the best overview about it at the moment.

yep. I think I'll re-fresh my printk_safe patch set tonight. it will
conflict with Linus' pr_cont() rework, so I'll keep my patch set as a
RFC.


> We are going to discuss a possible progress on Plumbers next week.

yep. I'll prepare some PDF slides :)


I'm afraid due to the lack of experience/time/"anything else that is
crucially important" I have no idea at the moment if my KS tech-topic
proposal [1][2] has been approved or rejected (is KS schedule available
somewhere online already? I can't find it) and I absolutely forgot to
submit it as a LPC micro-conference as a back-up plan (hm, can people
actually do this?). so in the worst case (printk tech-topic is out of KS
schedule) we will have to find an empty room on our own (I'm available
*any* time). my apologies for any incontinence in advance.

[1] https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2016-July/002740.html
[2] https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2016-September/004006.html

	-ss

      reply	other threads:[~2016-10-27 13:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 22:55 printk badness with VMAP_STACK Laura Abbott
2016-10-26 23:34 ` Linus Torvalds
2016-10-27  0:04   ` Laura Abbott
2016-10-27  9:19 ` Petr Mladek
2016-10-27 11:58   ` Sergey Senozhatsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161027115857.GA410@swordfish \
    --to=sergey.senozhatsky@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=keescook@chromium.org \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=pmladek@suse.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).