From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752984AbcJ1EI1 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 00:08:27 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:36097 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751157AbcJ1EIZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 00:08:25 -0400
Date: Fri, 28 Oct 2016 13:08:22 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Petr Mladek <pmladek@suse.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Jason Wessel <jason.wessel@windriver.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
        David Sterba <dsterba@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] printk/NMI: Handle continuous lines and missing
 newline
Message-ID: <20161028040822.GB612@swordfish>
References: <1477583574-30988-1-git-send-email-pmladek@suse.com>
 <1477583574-30988-2-git-send-email-pmladek@suse.com>
 <1477586125.30917.3.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1477586125.30917.3.camel@perches.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (10/27/16 09:35), Joe Perches wrote:
[..]
> > -	printk_nmi_flush_line(buf, (end - start) + 1);
> > +		/* Handle continuous lines or missing new line. */
> > +		if ((c + 1 < end) && printk_get_level(c)) {
> > +			if (header) {
> > +				c += 2;
> 
> printk_skip_level

agree, printk_skip_level() probably would look better here.
other than that, looks good to me. nice that you found it, Petr!

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

	-ss