From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Michael Holzheu <holzheu@linux.vnet.ibm.com>,
<linux-s390@vger.kernel.org>
Subject: Re: [PATCH 3/3] s390: char: make slp_ctl explicitly non-modular
Date: Sun, 30 Oct 2016 14:43:08 +0100 [thread overview]
Message-ID: <20161030144308.03a804de@mschwide> (raw)
In-Reply-To: <20161029203843.515-4-paul.gortmaker@windriver.com>
On Sat, 29 Oct 2016 16:38:43 -0400
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> The Makefile currently controlling compilation of this code is obj-y,
> meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular usage, so that when reading
> the driver there is no doubt it is builtin-only.
>
> Since module_misc_device translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> Cc: linux-s390@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
That idea behind the patch makes sense to me. But the built robot
reports a new warning which should be fixed. If that is done:
Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2016-10-30 13:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 20:38 [PATCH 0/3] Add new builtin_misc_device users Paul Gortmaker
2016-10-29 20:38 ` [PATCH 1/3] lightnvm: make core.c explicitly non-modular Paul Gortmaker
2016-10-29 22:01 ` kbuild test robot
2016-10-29 22:36 ` Paul Gortmaker
2016-10-29 20:38 ` [PATCH 2/3] blackfin: make-bf561/coreb.c " Paul Gortmaker
2016-10-30 1:02 ` kbuild test robot
2016-10-29 20:38 ` [PATCH 3/3] s390: char: make slp_ctl " Paul Gortmaker
2016-10-29 22:49 ` kbuild test robot
2016-10-30 13:43 ` Martin Schwidefsky [this message]
2016-10-30 16:04 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161030144308.03a804de@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox