From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754429AbcJ3PAA (ORCPT ); Sun, 30 Oct 2016 11:00:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38618 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752384AbcJ3O75 (ORCPT ); Sun, 30 Oct 2016 10:59:57 -0400 Date: Sun, 30 Oct 2016 10:59:59 -0400 From: Greg Kroah-Hartman To: James Simmons Cc: devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , "John L. Hammond" , Linux Kernel Mailing List , Lustre Development List Subject: Re: [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3 Message-ID: <20161030145959.GA31097@kroah.com> References: <1477606323-30325-1-git-send-email-jsimmons@infradead.org> <1477606323-30325-23-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477606323-30325-23-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 27, 2016 at 06:11:56PM -0400, James Simmons wrote: > From: John L. Hammond > > Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but > which allows setting of all three inode timestamps. Use this ioctl > during HSM restore to ensure that the volatile file has the same > timestamps as the file to be restored. Strengthen sanity-hsm test_24a > to check that archive, release, and restore do not change a file's > ctime. Add sanity-hsm test_24e to check that tar will succeed when it > encounters a HSM released file. This sounds odd, why is this filesystem the only one that needs a "special" futimes? Don't make up new syscalls by making an ioctl please, make a new syscall if that's what you really need! thanks, greg k-h