From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762098AbcJaIOL (ORCPT ); Mon, 31 Oct 2016 04:14:11 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:35854 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762047AbcJaIOG (ORCPT ); Mon, 31 Oct 2016 04:14:06 -0400 Date: Mon, 31 Oct 2016 08:16:43 +0000 From: Lee Jones To: Jonathan Cameron Cc: Mugunthan V N , linux-iio@vger.kernel.org, Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Vignesh R , "Andrew F . Davis" , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sekhar Nori , Peter Ujfalusi Subject: Re: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address Message-ID: <20161031081643.GN13127@dell> References: <20160921161134.6951-1-mugunthanvnm@ti.com> <20160921161134.6951-2-mugunthanvnm@ti.com> <20160927194045.GK21388@dell> <20161026121730.GS8574@dell> <954adfa7-94d9-f785-aeab-6f20c8f4c3b9@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <954adfa7-94d9-f785-aeab-6f20c8f4c3b9@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 Oct 2016, Jonathan Cameron wrote: > On 26/10/16 13:17, Lee Jones wrote: > > On Fri, 30 Sep 2016, Mugunthan V N wrote: > > > >> On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote: > >>> On Wed, 21 Sep 2016, Mugunthan V N wrote: > >>> > >>>> store the physical address of the device in its priv to use it > >>>> for DMA addressing in the client drivers. > >>>> > >>>> Signed-off-by: Mugunthan V N > >>>> --- > >>>> drivers/mfd/ti_am335x_tscadc.c | 1 + > >>>> include/linux/mfd/ti_am335x_tscadc.h | 1 + > >>>> 2 files changed, 2 insertions(+) > >>>> > >>>> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > >>>> index c8f027b..0f3fab4 100644 > >>>> --- a/drivers/mfd/ti_am335x_tscadc.c > >>>> +++ b/drivers/mfd/ti_am335x_tscadc.c > >>>> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) > >>>> tscadc->irq = err; > >>>> > >>>> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >>>> + tscadc->tscadc_phys_base = res->start; > >>> > >>> This is unusual. Can't you use a virt_to_phys() variant instead? > >>> > >> > >> I tried using virt_to_phys(), but its not working for me. > >> Also saw many drivers uses like this to get physical address > >> ("git grep -n " res->start;" drivers/*"). > > > > Very well: > > > > For my own reference: > > Acked-for-MFD-by: Lee Jones > > > > Let me know how you wish this set to be handled. > I'm happy to pick up the whole series. There are some more mfd > header changes in patch 2 but as they only add defines, I > don't mind that much if I don't an Ack from you on those > (btw this got to V3 but as patch 1 didn't change I'll carry > your ack forwards). > > Do you want an immutable branch? Seems unlikely to cause > much trouble even if there is a merge issue on all 10ish > lines of mfd code in the next merge window. Not at the moment, but if you could set things up so it's possible to create one at a later date if things go Pete Tong, that would be great. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog