Re: [PATCH 03/15] wm8350_power: use permission-specific DEVICE_ATTR variants

Sebastian Reichel
2016-11-23T23:10:16Z

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

Hi Julia,

On Sat, Oct 29, 2016 at 09:36:57PM +0200, Julia Lawall wrote:
> Use DEVICE_ATTR_RO for read only attributes. This simplifies the source
> code, improves readbility, and reduces the chance of inconsistencies.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @ro@
> declarer name DEVICE_ATTR;
> identifier x,x_show;
> @@
>
> DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
>
> @script:ocaml@
> x << ro.x;
> x_show << ro.x_show;
> @@
>
> if not (x^"_show" = x_show) then Coccilib.include_match false
>
> @@
> declarer name DEVICE_ATTR_RO;
> identifier ro.x,ro.x_show;
> @@
>
> - DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
> + DEVICE_ATTR_RO(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/power/supply/wm8350_power.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]