From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file operation
Date: Mon, 31 Oct 2016 14:07:54 +0100 [thread overview]
Message-ID: <20161031130754.GA9853@lst.de> (raw)
In-Reply-To: <20161030232331.GJ22126@dastard>
On Mon, Oct 31, 2016 at 10:23:31AM +1100, Dave Chinner wrote:
> This doesn't belong in this patchset.
It does. I can't fix up the calling conventions for a methods that
was never implemented.
> Regardless, can we just implement the damned thing rather than
> removing it? Plenty of people have asked for it and they still want
> this functionality. I've sent a couple of different prototypes that
> worked but got bikeshedded to death, and IIRC Ben also tried to get
> it implemented but that went nowhere because other parts of his
> patchset got bikeshedded to death.
>
> If nothing else, just let me implement it in XFS like I did the
> first time so when all the bikshedding stops we can convert it to
> the One True AIO Interface that is decided on.
I'm not going to complain about a proper implementation, but right now
we don't have any, and I'm not even sure the method signature is
all that suitable. E.g. for the in-kernel users we'd really want a
ranged fsync like the normal fsync anyway.
next prev parent reply other threads:[~2016-10-31 13:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 16:42 aio fixes for use after free and freeze protection Christoph Hellwig
2016-10-30 16:42 ` [PATCH 1/4] aio: hold an extra file reference over AIO read/write operations Christoph Hellwig
2016-10-30 16:42 ` [PATCH 2/4] fs: remove the never implemented aio_fsync file operation Christoph Hellwig
2016-10-30 23:23 ` Dave Chinner
2016-10-31 13:07 ` Christoph Hellwig [this message]
2016-10-31 20:25 ` Dave Chinner
2016-11-01 1:30 ` Linus Torvalds
2016-11-01 14:30 ` Christoph Hellwig
2016-11-01 15:07 ` Linus Torvalds
2016-11-01 14:25 ` Christoph Hellwig
2016-10-30 16:42 ` [PATCH 3/4] fs: remove aio_run_iocb Christoph Hellwig
2016-10-30 16:42 ` [PATCH 4/4] aio: fix freeze protection of aio writes Christoph Hellwig
2016-10-30 16:58 ` aio fixes for use after free and freeze protection Al Viro
2016-10-30 17:01 ` Christoph Hellwig
2016-11-09 2:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031130754.GA9853@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox