From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rob Herring <robh@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Laura Abbott <labbott@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger
Date: Mon, 31 Oct 2016 09:07:24 -0600 [thread overview]
Message-ID: <20161031150724.GA3687@kroah.com> (raw)
In-Reply-To: <CAL_JsqJsPhy_ATTaTH8H2kaAQP04V1Huiv5J-SQM=CMBq5hmSQ@mail.gmail.com>
On Mon, Oct 31, 2016 at 09:10:57AM -0500, Rob Herring wrote:
> On Mon, Oct 31, 2016 at 7:28 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > Hi Greg,
> >
> > On Mon, Oct 31, 2016 at 1:21 PM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> >> On Mon, Oct 31, 2016 at 11:12:45AM +0100, Geert Uytterhoeven wrote:
> >>> On Fri, Oct 7, 2016 at 6:09 PM, Laura Abbott <labbott@redhat.com> wrote:
> >>> > The current state of driver removal is not great.
> >>> > CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text
> >>> > currently undersells exactly how many errors this option will find. Add
> >>> > a bit more description to indicate this option shouldn't be turned on
> >>> > unless you actually want to debug driver removal. The text can be
> >>> > changed later when more drivers are fixed up.
> >>>
> >>> Indeed, this is failing miserably for e.g. SoC clock drivers using
> >>> platform_driver_probe(), which are never retried, rendering the complete
> >>> system useless.
> >>
> >> Why are they never retried?
> >
> > Because platform_driver_probe() is meant for non-hotpluggable devices,
> > and unregisters the platform driver immediately if probe fails.
> > See also the comments for __platform_driver_probe():
>
> My patch "driver core: skip removal test for non-removable drivers"
> fixes this case. It seems to have dropped from Greg's queue, so I'll
> resend.
Odd, I don't see that anywhere here, sorry about that...
next prev parent reply other threads:[~2016-10-31 15:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 23:53 CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott
2016-10-07 3:56 ` Greg Kroah-Hartman
2016-10-07 15:40 ` Laura Abbott
2016-10-07 4:06 ` Rob Herring
2016-10-07 15:45 ` Laura Abbott
2016-10-07 16:09 ` [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Laura Abbott
2016-10-31 10:12 ` Geert Uytterhoeven
2016-10-31 12:21 ` Greg Kroah-Hartman
2016-10-31 12:28 ` Geert Uytterhoeven
2016-10-31 14:10 ` Rob Herring
2016-10-31 15:07 ` Greg Kroah-Hartman [this message]
2016-10-31 15:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031150724.GA3687@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=labbott@redhat.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).