public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
	Alexander Graf <agraf@suse.com>,
	Ming@suse.de, "Lei <tom.leiming"@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] loop: Enable correct physical blocksize
Date: Tue, 1 Nov 2016 15:00:33 +0100	[thread overview]
Message-ID: <20161101140033.GA16815@lst.de> (raw)
In-Reply-To: <1477942639-109971-3-git-send-email-hare@suse.de>

On Mon, Oct 31, 2016 at 08:37:17PM +0100, Hannes Reinecke wrote:
> When running on files the physical blocksize is actually 4k,

Is it?  Independent of that sentence the patch looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2016-11-01 14:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 19:37 [PATCHv3 0/4] loop: enable different physical blocksizes Hannes Reinecke
2016-10-31 19:37 ` [PATCH 1/4] loop: Remove unused 'bdev' argument from loop_set_capacity Hannes Reinecke
2016-10-31 21:26   ` Ming Lei
2016-10-31 19:37 ` [PATCH 2/4] loop: Enable correct physical blocksize Hannes Reinecke
2016-11-01 14:00   ` Christoph Hellwig [this message]
2016-10-31 19:37 ` [PATCH 3/4] loop: Add 'lo_logical_blocksize' Hannes Reinecke
2016-11-01 14:01   ` Christoph Hellwig
2016-11-01 16:57     ` Hannes Reinecke
2016-10-31 19:37 ` [PATCH 4/4] loop: Pass logical blocksize in 'lo_init[0]' ioctl field Hannes Reinecke
2016-11-01 14:02   ` Christoph Hellwig
2016-11-01 16:58     ` Hannes Reinecke
2016-11-03 13:26     ` Hannes Reinecke
  -- strict thread matches above, loose matches on Subject: below --
2015-08-07  8:54 [PATCHv2 0/4] loop: enable different physical blocksizes Hannes Reinecke
2015-08-07  8:54 ` [PATCH 2/4] loop: Enable correct physical blocksize Hannes Reinecke
2015-08-10  7:50   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161101140033.GA16815@lst.de \
    --to=hch@lst.de \
    --cc="Lei <tom.leiming"@gmail.com \
    --cc=Ming@suse.de \
    --cc=agraf@suse.com \
    --cc=axboe@fb.com \
    --cc=hare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox