public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robin van der Gracht <robin@protonic.nl>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: Sean Paul <seanpaul@chromium.org>,
	Greg Kroah-Hartman <gregkh@google.com>,
	linux-kernel@vger.kernel.org
Subject: [char-misc:char-misc-testing] warning
Date: Tue, 1 Nov 2016 15:07:02 +0100	[thread overview]
Message-ID: <20161101150702.00a6379f@erd979> (raw)

[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]

Hi Tobias,

Lately I've submitted patches to Gregs (char-misc) git repo and they got
bounced because the kbuild bot threw a warning:

warning: (PMAC_BACKLIGHT && DRM_NOUVEAU && HT16K33 && FB_TFT) selects
FB_BACKLIGHT which has unmet direct dependencies (HAS_IOMEM && FB)

My patched added a new driver named HT16K33, but..

I believe the warning is the result of a dependency issue made possible by this commit:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/gregkh/char-misc/+/fc497ed8361f34e465f31e9babcb88efe38fe433

The kbuild bots configuration file stated:
CONFIG_HAS_IOMEM=y
CONFIG_DRM_NOUVEAU=y
CONFIG_DRM_NOUVEAU_BACKLIGHT=y
CONFIG_FB_BACKLIGHT=y
# CONFIG_FB is not set

PMAC_BACKLIGHT, HT16K33 and FB_TFT ware not mentioned in the config file.
I've attached the config file to this email.

FB_BACKLIGHT depends on FB like so:

(drivers/video/fbdev/Kconfig)
config FB_BACKLIGHT
	bool
	depends on FB
	...

In your commit the 'select FB' is removed from the config DRM_NOUVEAU in
the drivers/gpu/drm/nouveau/Kconfig file but DRM_NOUVEAU still selects
FB_BACKLIGHT when using DRM_NOUVEAU_BACKLIGHT.

Is no one else selects FB, the warning mentioned above is raised.

Would you like to verify this?

Regards,

-- 
Robin van der Gracht
Protonic Holland

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26724 bytes --]

             reply	other threads:[~2016-11-01 14:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 14:07 Robin van der Gracht [this message]
2016-11-01 15:33 ` [char-misc:char-misc-testing] warning Tobias Jakobi
2016-11-01 16:02   ` Robin van der Gracht
2016-11-01 16:34     ` Randy Dunlap
2016-11-02  7:23       ` Robin van der Gracht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161101150702.00a6379f@erd979 \
    --to=robin@protonic.nl \
    --cc=gregkh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox