Re: [PATCH 2/4] Staging: vme: Use BIT macro for bit field definitions.

Dan Carpenter
2016-11-10T19:18:27Z

On Wed, Nov 02, 2016 at 01:27:09AM +0300, Anton Leshchenko wrote:
> #define PIO2_CNTR_MODE0 0
> -#define PIO2_CNTR_MODE1 (1 << 1)
> -#define PIO2_CNTR_MODE2 (2 << 1)
> -#define PIO2_CNTR_MODE3 (3 << 1)
> -#define PIO2_CNTR_MODE4 (4 << 1)
> -#define PIO2_CNTR_MODE5 (5 << 1)
> +#define PIO2_CNTR_MODE1 BIT(1)
> +#define PIO2_CNTR_MODE2 BIT(2)
> +#define PIO2_CNTR_MODE3 (BIT(1) | BIT(2))
> +#define PIO2_CNTR_MODE4 BIT(4)

This should be BIT(3)

> +#define PIO2_CNTR_MODE5 (BIT(1) | BIT(3))

regards,
dan carpenter