From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbcKBHhF (ORCPT ); Wed, 2 Nov 2016 03:37:05 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:36207 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbcKBHhC (ORCPT ); Wed, 2 Nov 2016 03:37:02 -0400 Date: Wed, 2 Nov 2016 15:36:56 +0800 From: Daniel Hung-yu Wu To: Olof Johansson , Lee Jones Cc: hywu@chromium.org, drinkcat@chromium.org, kyan@chromium.org, linux-kernel@vger.kernel.org Subject: [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works Message-ID: <20161102073653.GA5351@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch applies on top of "mfd: cros_ec: Add EC console read structures definitions" (https://patchwork.kernel.org/patch/9294887/). Reboot or shutdown during delayed works could corrupt communication with EC, and certain I2C controller may not be able to recover from the error state. BUG=chrome-os-partner:58823 TEST=factory run-in test for 200+ times Signed-off-by: Daniel Hung-yu Wu --- drivers/platform/chrome/cros_ec_dev.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c index 7d51f69..137c0ce 100644 --- a/drivers/platform/chrome/cros_ec_dev.c +++ b/drivers/platform/chrome/cros_ec_dev.c @@ -308,6 +308,14 @@ static int ec_device_remove(struct platform_device *pdev) return 0; } +static void ec_device_shutdown(struct platform_device *pdev) +{ + struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev); + + /* Be sure to clear up debugfs delayed works */ + cros_ec_debugfs_remove(ec); +} + static const struct platform_device_id cros_ec_id[] = { { "cros-ec-ctl", 0 }, { /* sentinel */ }, @@ -320,6 +328,7 @@ static struct platform_driver cros_ec_dev_driver = { }, .probe = ec_device_probe, .remove = ec_device_remove, + .shutdown = ec_device_shutdown, }; static int __init cros_ec_dev_init(void) -- 2.8.0.rc3.226.g39d4020