* [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works
@ 2016-11-02 7:36 Daniel Hung-yu Wu
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Hung-yu Wu @ 2016-11-02 7:36 UTC (permalink / raw)
To: Olof Johansson, Lee Jones; +Cc: hywu, drinkcat, kyan, linux-kernel
This patch applies on top of "mfd: cros_ec: Add EC console read structures
definitions" (https://patchwork.kernel.org/patch/9294887/).
Reboot or shutdown during delayed works could corrupt
communication with EC, and certain I2C controller may not
be able to recover from the error state.
BUG=chrome-os-partner:58823
TEST=factory run-in test for 200+ times
Signed-off-by: Daniel Hung-yu Wu <hywu@chromium.org>
---
drivers/platform/chrome/cros_ec_dev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
index 7d51f69..137c0ce 100644
--- a/drivers/platform/chrome/cros_ec_dev.c
+++ b/drivers/platform/chrome/cros_ec_dev.c
@@ -308,6 +308,14 @@ static int ec_device_remove(struct platform_device *pdev)
return 0;
}
+static void ec_device_shutdown(struct platform_device *pdev)
+{
+ struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
+
+ /* Be sure to clear up debugfs delayed works */
+ cros_ec_debugfs_remove(ec);
+}
+
static const struct platform_device_id cros_ec_id[] = {
{ "cros-ec-ctl", 0 },
{ /* sentinel */ },
@@ -320,6 +328,7 @@ static struct platform_driver cros_ec_dev_driver = {
},
.probe = ec_device_probe,
.remove = ec_device_remove,
+ .shutdown = ec_device_shutdown,
};
static int __init cros_ec_dev_init(void)
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works
@ 2016-10-24 7:53 Daniel Hung-yu Wu
2016-10-26 14:04 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Hung-yu Wu @ 2016-10-24 7:53 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones; +Cc: hywu, ejcaruso, drinkcat, kyan, linux-kernel
This patch applies on top of "mfd: cros_ec: Add EC console read structures
definitions" (https://patchwork.kernel.org/patch/9294887/).
This patch is currently against a linux 3.18 kernel.
Reboot or shutdown during delayed works could corrupt communication with EC,
and certain I2C controller may not be able to recover from the error state.
A shutdown function is registered to clear delayed works or wait for them to
finish.
Signed-off-by: Daniel Hung-yu Wu <hywu@chromium.org>
---
drivers/mfd/cros_ec_dev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 8618a7c..3e548f1 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -613,6 +613,14 @@ static int ec_device_remove(struct platform_device *pdev)
return 0;
}
+static void ec_device_shutdown(struct platform_device *pdev)
+{
+ struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
+
+ /* Be sure to clear up debugfs delayed works */
+ cros_ec_debugfs_remove(ec);
+}
+
static int ec_device_suspend(struct device *dev)
{
struct cros_ec_dev *ec = dev_get_drvdata(dev);
@@ -656,6 +664,7 @@ static struct platform_driver cros_ec_dev_driver = {
},
.probe = ec_device_probe,
.remove = ec_device_remove,
+ .shutdown = ec_device_shutdown,
};
static int __init cros_ec_dev_init(void)
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works
2016-10-24 7:53 Daniel Hung-yu Wu
@ 2016-10-26 14:04 ` Lee Jones
2016-10-26 14:22 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2016-10-26 14:04 UTC (permalink / raw)
To: Daniel Hung-yu Wu
Cc: Samuel Ortiz, hywu, ejcaruso, drinkcat, kyan, linux-kernel
On Mon, 24 Oct 2016, Daniel Hung-yu Wu wrote:
> This patch applies on top of "mfd: cros_ec: Add EC console read structures
> definitions" (https://patchwork.kernel.org/patch/9294887/).
>
> This patch is currently against a linux 3.18 kernel.
>
> Reboot or shutdown during delayed works could corrupt communication with EC,
> and certain I2C controller may not be able to recover from the error state.
> A shutdown function is registered to clear delayed works or wait for them to
> finish.
>
> Signed-off-by: Daniel Hung-yu Wu <hywu@chromium.org>
> ---
> drivers/mfd/cros_ec_dev.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 8618a7c..3e548f1 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -613,6 +613,14 @@ static int ec_device_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static void ec_device_shutdown(struct platform_device *pdev)
> +{
> + struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
> +
> + /* Be sure to clear up debugfs delayed works */
> + cros_ec_debugfs_remove(ec);
> +}
> +
> static int ec_device_suspend(struct device *dev)
> {
> struct cros_ec_dev *ec = dev_get_drvdata(dev);
> @@ -656,6 +664,7 @@ static struct platform_driver cros_ec_dev_driver = {
> },
> .probe = ec_device_probe,
> .remove = ec_device_remove,
> + .shutdown = ec_device_shutdown,
> };
>
> static int __init cros_ec_dev_init(void)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works
2016-10-26 14:04 ` Lee Jones
@ 2016-10-26 14:22 ` Lee Jones
2016-11-02 7:59 ` Daniel Hung-yu Wu
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2016-10-26 14:22 UTC (permalink / raw)
To: Daniel Hung-yu Wu
Cc: Samuel Ortiz, hywu, ejcaruso, drinkcat, kyan, linux-kernel
On Wed, 26 Oct 2016, Lee Jones wrote:
> On Mon, 24 Oct 2016, Daniel Hung-yu Wu wrote:
>
> > This patch applies on top of "mfd: cros_ec: Add EC console read structures
> > definitions" (https://patchwork.kernel.org/patch/9294887/).
> >
> > This patch is currently against a linux 3.18 kernel.
> >
> > Reboot or shutdown during delayed works could corrupt communication with EC,
> > and certain I2C controller may not be able to recover from the error state.
> > A shutdown function is registered to clear delayed works or wait for them to
> > finish.
> >
> > Signed-off-by: Daniel Hung-yu Wu <hywu@chromium.org>
> > ---
> > drivers/mfd/cros_ec_dev.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
>
> Applied, thanks.
Ah, I thought you'd at least ported it to Mainline!
You need to do that before posting patches.
> > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > index 8618a7c..3e548f1 100644
> > --- a/drivers/mfd/cros_ec_dev.c
> > +++ b/drivers/mfd/cros_ec_dev.c
> > @@ -613,6 +613,14 @@ static int ec_device_remove(struct platform_device *pdev)
> > return 0;
> > }
> >
> > +static void ec_device_shutdown(struct platform_device *pdev)
> > +{
> > + struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
> > +
> > + /* Be sure to clear up debugfs delayed works */
> > + cros_ec_debugfs_remove(ec);
> > +}
> > +
> > static int ec_device_suspend(struct device *dev)
> > {
> > struct cros_ec_dev *ec = dev_get_drvdata(dev);
> > @@ -656,6 +664,7 @@ static struct platform_driver cros_ec_dev_driver = {
> > },
> > .probe = ec_device_probe,
> > .remove = ec_device_remove,
> > + .shutdown = ec_device_shutdown,
> > };
> >
> > static int __init cros_ec_dev_init(void)
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works
2016-10-26 14:22 ` Lee Jones
@ 2016-11-02 7:59 ` Daniel Hung-yu Wu
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Hung-yu Wu @ 2016-11-02 7:59 UTC (permalink / raw)
To: Lee Jones; +Cc: Samuel Ortiz, hywu, ejcaruso, drinkcat, kyan, linux-kernel
On Wed, Oct 26, 2016 at 03:22:14PM +0100, Lee Jones wrote:
> On Wed, 26 Oct 2016, Lee Jones wrote:
>
> > On Mon, 24 Oct 2016, Daniel Hung-yu Wu wrote:
> >
> > > This patch applies on top of "mfd: cros_ec: Add EC console read structures
> > > definitions" (https://patchwork.kernel.org/patch/9294887/).
> > >
> > > This patch is currently against a linux 3.18 kernel.
> > >
> > > Reboot or shutdown during delayed works could corrupt communication with EC,
> > > and certain I2C controller may not be able to recover from the error state.
> > > A shutdown function is registered to clear delayed works or wait for them to
> > > finish.
> > >
> > > Signed-off-by: Daniel Hung-yu Wu <hywu@chromium.org>
> > > ---
> > > drivers/mfd/cros_ec_dev.c | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> >
> > Applied, thanks.
>
> Ah, I thought you'd at least ported it to Mainline!
>
> You need to do that before posting patches.
>
> > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > > index 8618a7c..3e548f1 100644
> > > --- a/drivers/mfd/cros_ec_dev.c
> > > +++ b/drivers/mfd/cros_ec_dev.c
> > > @@ -613,6 +613,14 @@ static int ec_device_remove(struct platform_device *pdev)
> > > return 0;
> > > }
> > >
> > > +static void ec_device_shutdown(struct platform_device *pdev)
> > > +{
> > > + struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev);
> > > +
> > > + /* Be sure to clear up debugfs delayed works */
> > > + cros_ec_debugfs_remove(ec);
> > > +}
> > > +
> > > static int ec_device_suspend(struct device *dev)
> > > {
> > > struct cros_ec_dev *ec = dev_get_drvdata(dev);
> > > @@ -656,6 +664,7 @@ static struct platform_driver cros_ec_dev_driver = {
> > > },
> > > .probe = ec_device_probe,
> > > .remove = ec_device_remove,
> > > + .shutdown = ec_device_shutdown,
> > > };
> > >
> > > static int __init cros_ec_dev_init(void)
> >
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
The patch for Mainline is submitted. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-02 7:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-02 7:36 [PATCH] CHROMIUM: ec: register shutdown function to clear delayed works Daniel Hung-yu Wu
-- strict thread matches above, loose matches on Subject: below --
2016-10-24 7:53 Daniel Hung-yu Wu
2016-10-26 14:04 ` Lee Jones
2016-10-26 14:22 ` Lee Jones
2016-11-02 7:59 ` Daniel Hung-yu Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).