Re: [PATCH] PM / sleep: fix device reference leak in test_suspend

Pavel Machek
2016-11-02T08:52:34Z

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Tue 2016-11-01 11:49:56, Johan Hovold wrote:
> Make sure to drop the reference taken by class_find_device() after
> opening the rtc device.
>
> Fixes: 77437fd4e61f ("pm: boot time suspend selftest")
> Signed-off-by: Johan Hovold <johan@kernel.org>

Acked-by: Pavel Machek <pavel@ucw.cz>

> ---
> kernel/power/suspend_test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
> index 084452e34a12..bdff5ed57f10 100644
> --- a/kernel/power/suspend_test.c
> +++ b/kernel/power/suspend_test.c
> @@ -203,8 +203,10 @@ static int __init test_suspend(void)
>
> /* RTCs have initialized by now too ... can we use one? */
> dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
> - if (dev)
> + if (dev) {
> rtc = rtc_class_open(dev_name(dev));
> + put_device(dev);
> + }
> if (!rtc) {
> printk(warn_no_rtc);
> return 0;

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]