From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Patrice Chotard <patrice.chotard@st.com>,
Amelie Delaunay <amelie.delaunay@st.com>
Subject: Re: [PATCH] mfd: stmpe: Fix RESET regression on STMPE2401
Date: Wed, 2 Nov 2016 14:39:58 +0000 [thread overview]
Message-ID: <20161102143958.GW13127@dell> (raw)
In-Reply-To: <1477992173-30964-1-git-send-email-linus.walleij@linaro.org>
On Tue, 01 Nov 2016, Linus Walleij wrote:
> Since commit c4dd1ba355aae2bc3d1213da6c66c53e3c31e028
> ("mfd: stmpe: Add reset support for all STMPE variant")
> we're resetting the STMPE expanders before use.
>
> This caused a regression on the STMP2401 on the Nomadik
> NHK8815:
>
> stmpe-i2c 0-0043: stmpe2401 detected, chip id: 0x101
> nmk-i2c 101f8000.i2c0: write to slave 0x43 timed out
> nmk-i2c 101f8000.i2c0: no ack received after address transmission
> stmpe-i2c 0-0044: stmpe2401 detected, chip id: 0x101
> nmk-i2c 101f8000.i2c0: write to slave 0x44 timed out
> nmk-i2c 101f8000.i2c0: no ack received after address transmission
>
> It turns out that we start to poll for the reset bit to
> go low again too quickly: the STMPE2401 is not yet online and
> ready to be asked for the status of the RESET bit.
>
> By introducing a 10ms delay before starting to hammer
> the register for information, we get back to normal:
>
> stmpe-i2c 0-0043: stmpe2401 detected, chip id: 0x101
> stmpe-i2c 0-0044: stmpe2401 detected, chip id: 0x101
>
> Cc: stable@vger.kernel.org
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Cc: Amelie Delaunay <amelie.delaunay@st.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Fixes: c4dd1ba355aa ("mfd: stmpe: Add reset support for all STMPE variant")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> drivers/mfd/stmpe.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied to -fixes.
> diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c
> index cfdae8a3d779..b0c7bcdaf5df 100644
> --- a/drivers/mfd/stmpe.c
> +++ b/drivers/mfd/stmpe.c
> @@ -851,6 +851,8 @@ static int stmpe_reset(struct stmpe *stmpe)
> if (ret < 0)
> return ret;
>
> + msleep(10);
> +
> timeout = jiffies + msecs_to_jiffies(100);
> while (time_before(jiffies, timeout)) {
> ret = __stmpe_reg_read(stmpe, stmpe->regs[STMPE_IDX_SYS_CTRL]);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-11-02 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 9:22 [PATCH] mfd: stmpe: Fix RESET regression on STMPE2401 Linus Walleij
2016-11-02 13:14 ` Patrice Chotard
2016-11-02 14:39 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102143958.GW13127@dell \
--to=lee.jones@linaro.org \
--cc=amelie.delaunay@st.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrice.chotard@st.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox