From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932575AbcKBRJN (ORCPT ); Wed, 2 Nov 2016 13:09:13 -0400 Received: from foss.arm.com ([217.140.101.70]:48580 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932480AbcKBRJL (ORCPT ); Wed, 2 Nov 2016 13:09:11 -0400 Date: Wed, 2 Nov 2016 11:08:06 -0600 From: Catalin Marinas To: Alexey Brodkin Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Vineet Gupta , Marek Szyprowski , stable@vger.kernel.org Subject: Re: [PATCH] arc: Implement arch-specific dma_map_ops.mmap Message-ID: <20161102170806.z3k3nlczspg2ebxb@localhost> References: <1478089183-6458-1-git-send-email-abrodkin@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478089183-6458-1-git-send-email-abrodkin@synopsys.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2016 at 03:19:43PM +0300, Alexey Brodkin wrote: > diff --git a/arch/arc/mm/dma.c b/arch/arc/mm/dma.c > index 20afc65e22dc..034ec6a8a764 100644 > --- a/arch/arc/mm/dma.c > +++ b/arch/arc/mm/dma.c > @@ -105,6 +105,31 @@ static void arc_dma_free(struct device *dev, size_t size, void *vaddr, > __free_pages(page, get_order(size)); > } > > +static int arc_dma_mmap(struct device *dev, struct vm_area_struct *vma, > + void *cpu_addr, dma_addr_t dma_addr, size_t size, > + unsigned long attrs) > +{ > + unsigned long user_count = vma_pages(vma); > + unsigned long count = PAGE_ALIGN(size) >> PAGE_SHIFT; > + unsigned long pfn = __phys_to_pfn(dma_addr); I don't think that's correct in all situations. Better as (for arc): unsigned long pfn = __phys_to_pfn(plat_dma_to_phys(dma_addr)); Other than that: Reviewed-by: Catalin Marinas