From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jordan Crouse <jcrouse@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency
Date: Wed, 2 Nov 2016 13:04:27 -0700 [thread overview]
Message-ID: <20161102200427.GP25787@tuxbot> (raw)
In-Reply-To: <67b6f5ae-378e-9306-c717-2529ae84f9f7@codeaurora.org>
On Wed 02 Nov 12:24 PDT 2016, Sarangdhar Joshi wrote:
> On 11/01/2016 04:11 PM, Stephen Boyd wrote:
> >On 10/28, Sarangdhar Joshi wrote:
> >>@@ -380,33 +384,43 @@ EXPORT_SYMBOL(qcom_scm_is_available);
> >> static int qcom_scm_probe(struct platform_device *pdev)
> >> {
> >> struct qcom_scm *scm;
> >>+ uint64_t clks;
> >> int ret;
> >>
> >> scm = devm_kzalloc(&pdev->dev, sizeof(*scm), GFP_KERNEL);
> >> if (!scm)
> >> return -ENOMEM;
> >>
> >>- scm->core_clk = devm_clk_get(&pdev->dev, "core");
> >>- if (IS_ERR(scm->core_clk)) {
> >>- if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER)
> >>- return PTR_ERR(scm->core_clk);
> >>+ clks = (uint64_t)of_device_get_match_data(&pdev->dev);
> >>+ if (clks & SCM_HAS_CORE_CLK) {
> >>+ scm->core_clk = devm_clk_get(&pdev->dev, "core");
> >>+ if (IS_ERR(scm->core_clk)) {
> >>+ if (PTR_ERR(scm->core_clk) == -EPROBE_DEFER)
> >>+ return PTR_ERR(scm->core_clk);
> >>
> >>- scm->core_clk = NULL;
> >>+ scm->core_clk = NULL;
> >>+ }
> >> }
> >>
> >> if (of_device_is_compatible(pdev->dev.of_node, "qcom,scm")) {
> >
> >Why didn't this also get added to the flags feature? I'd prefer
> >we either use of_device_is_compatible() for everything, or device
> >data to figure out what quirks to apply.
>
> You're right. These flags are already added for "qcom,scm" compatible. We
> can modify this to honor data flags only. I hope it's okay to update it in
> the same patch?
>
Yes, you're replacing the old conditional with a set of new ones, so it
should go in this patch.
Regards,
Bjorn
next prev parent reply other threads:[~2016-11-02 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 0:08 [PATCH 0/3] Remove clocks dependency from SCM driver Sarangdhar Joshi
2016-10-29 0:08 ` [PATCH 1/3] dt-bindings: firmware: scm: Add MSM8996 DT bindings Sarangdhar Joshi
2016-10-31 6:23 ` Rob Herring
2016-10-29 0:08 ` [PATCH 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency Sarangdhar Joshi
2016-10-29 2:31 ` kbuild test robot
2016-11-01 23:11 ` Stephen Boyd
2016-11-02 19:24 ` Sarangdhar Joshi
2016-11-02 20:04 ` Bjorn Andersson [this message]
2016-10-29 0:08 ` [PATCH 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Sarangdhar Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102200427.GP25787@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=spjoshi@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).