From: Jean Delvare <jdelvare@suse.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Markus Elfring <elfring@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] coding-style: fix mismatch of jump label name
Date: Wed, 2 Nov 2016 20:26:43 +0100 [thread overview]
Message-ID: <20161102202643.61d1cab2@endymion> (raw)
In-Reply-To: <1478105854-11867-1-git-send-email-yamada.masahiro@socionext.com>
Hi Masahiro-san,
On Thu, 3 Nov 2016 01:57:34 +0900, Masahiro Yamada wrote:
> Commit 865a1caa4b6b ("CodingStyle: Clarify and complete chapter 7")
> renamed the label "out_buffer" to "out_free_buffer", but missed to
> change this line.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Note:
> This patch is based on linux-next.
> The Documentation/CodingStyle was moved to
> Documentation/process/coding-style.rst
>
> Documentation/process/coding-style.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/process/coding-style.rst b/Documentation/process/coding-style.rst
> index 968808be..3e79051 100644
> --- a/Documentation/process/coding-style.rst
> +++ b/Documentation/process/coding-style.rst
> @@ -475,7 +475,7 @@ The rationale for using gotos is:
> ...
> }
> result = 1;
> - goto out_buffer;
> + goto out_free_buffer;
> }
> ...
> out_free_buffer:
Oops, my bad. Good catch.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Feel free to add a Fixes: tag, although I doubt this kind of
documentation patch is often backported, so it probably doesn't really
matter.
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-11-02 19:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 16:57 [PATCH] coding-style: fix mismatch of jump label name Masahiro Yamada
2016-11-02 19:26 ` Jean Delvare [this message]
2016-11-08 2:05 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102202643.61d1cab2@endymion \
--to=jdelvare@suse.de \
--cc=corbet@lwn.net \
--cc=elfring@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mchehab@s-opensource.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox