From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755822AbcKCIjM (ORCPT ); Thu, 3 Nov 2016 04:39:12 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:38072 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754647AbcKCIjI (ORCPT ); Thu, 3 Nov 2016 04:39:08 -0400 Date: Thu, 3 Nov 2016 08:41:47 +0000 From: Lee Jones To: Richard Vidal-Dorsch Cc: linus.walleij@linaro.org, gnurou@gmail.com, jdelvare@suse.com, linux@roeck-us.net, wsa@the-dreams.de, jingoohan1@gmail.com, tomi.valkeinen@ti.com, wim@iguana.be, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, k.kozlowski@samsung.com, jo.sunga@advantech.com, weilun.huang@advantech.com, andrew.chou@advantech.com Subject: Re: [PATCH v4 1/6] Add Advantech iManager MFD core driver Message-ID: <20161103084147.GY13127@dell> References: <20161102083751.6335-1-richard.dorsch@gmail.com> <20161102083751.6335-2-richard.dorsch@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161102083751.6335-2-richard.dorsch@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Nov 2016, Richard Vidal-Dorsch wrote: > This patch adds Advantech iManager Embedded Controller MFD core driver. > This mfd core dirver provides an interface for GPIO, I2C, HWmon, > Watchdog, and Backlight/Brightness control. > > Signed-off-by: Richard Vidal-Dorsch > --- > drivers/mfd/Kconfig | 18 + > drivers/mfd/Makefile | 1 + > drivers/mfd/imanager-core.c | 941 ++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/imanager-ec.h | 228 ++++++++++ > include/linux/mfd/imanager.h | 221 ++++++++++ > 5 files changed, 1409 insertions(+) > create mode 100644 drivers/mfd/imanager-core.c > create mode 100644 include/linux/mfd/imanager-ec.h > create mode 100644 include/linux/mfd/imanager.h After a brief review, it is my belief that this looks like a platform driver, which should live in drivers/platform/. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog