From: Sandeep Jain <Sandeep_Jain@mentor.com>
To: Richard Weinberger <richard.weinberger@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Steve Longerbeam <steve_longerbeam@mentor.com>,
Jim Baxter <jim_baxter@mentor.com>
Subject: Re: [PATCH] mtd: Allocate bdi objects dynamically
Date: Thu, 3 Nov 2016 17:04:22 +0530 [thread overview]
Message-ID: <20161103113421.GA4873@mentor.com> (raw)
In-Reply-To: <CAFLxGvx6B02c+HgYwJ8exVLT6owrkQL1Rq+X6VzUDKVUxE=aoQ@mail.gmail.com>
Dear Maintainers,
This patch is reviewed by Richard.
Requesting for Maintainer's attention for patch merge.
Thanks & Regards,
Sandeep Jain
On Sat, Sep 17, 2016 at 04:41:47PM +0200, Richard Weinberger wrote:
> On Thu, Aug 4, 2016 at 4:01 PM, Sandeep Jain <Sandeep_Jain@mentor.com> wrote:
> > From: Steve Longerbeam <steve_longerbeam@mentor.com>
> >
> > The MTD backing dev info objects mtd_bdi was statically allocated.
> > So when MTD is built as a loadable module, this object fall in the
> > vmalloc address space.
> >
> > The problem with that, is that the BDI APIs use wake_up_bit(), which calls
> > virt_to_page() to retrieve the memory zone of the page containing the
> > wait_queue to wake up, and virt_to_page() is not valid for vmalloc or
> > highmem addresses.
> >
> > Fix this by allocating the BDI objects dynamically with kmalloc. The
> > objects now fall in the logical address space so that BDI APIs will
> > work in all cases (mtd builtin or module).
> >
> > Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com>
> > Signed-off-by: Jim Baxter <jim_baxter@mentor.com>
> > Signed-off-by: Sandeep Jain <Sandeep_Jain@mentor.com>
>
> Reviewed-by: Richard Weinberger <richard@nod.at>
>
> --
> Thanks,
> //richard
next prev parent reply other threads:[~2016-11-03 11:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Sandeep Jain <Sandeep_Jain@mentor.com>
2016-08-04 14:01 ` [PATCH] mtd: Allocate bdi objects dynamically Sandeep Jain
2016-09-17 14:41 ` Richard Weinberger
2016-11-03 11:34 ` Sandeep Jain [this message]
2016-11-05 7:22 ` Marek Vasut
2016-11-29 8:12 ` Sandeep Jain
2016-12-01 15:39 ` Marek Vasut
2016-12-01 18:14 ` Brian Norris
2016-12-01 18:18 ` Marek Vasut
2016-08-04 14:16 ` [PATCH v1 0/2] mtd: lock module while used Sandeep Jain
2016-08-04 14:16 ` [PATCH v1 1/2] mtd: m25p80: " Sandeep Jain
2016-11-03 11:39 ` Sandeep Jain
2016-11-05 7:24 ` Marek Vasut
2016-12-01 19:10 ` Brian Norris
2016-08-04 14:16 ` [PATCH v1 2/2] mtd: Add hooks to call get and put on mtd devices Sandeep Jain
2016-08-04 17:32 ` Richard Weinberger
2016-08-05 11:54 ` Baxter, Jim
2016-08-05 12:13 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103113421.GA4873@mentor.com \
--to=sandeep_jain@mentor.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jim_baxter@mentor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
--cc=steve_longerbeam@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).