From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759719AbcKCV0v (ORCPT ); Thu, 3 Nov 2016 17:26:51 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37473 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756492AbcKCV0t (ORCPT ); Thu, 3 Nov 2016 17:26:49 -0400 Date: Thu, 3 Nov 2016 21:26:46 +0000 From: Matt Fleming To: Paul Bolle Cc: "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , David Howells , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/boot: Remove always empty $(USERINCLUDE) Message-ID: <20161103212646.GB8845@codeblueprint.co.uk> References: <1478166468-9760-1-git-send-email-pebolle@tiscali.nl> <1478166698.8359.4.camel@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1478166698.8359.4.camel@tiscali.nl> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 03 Nov, at 10:51:38AM, Paul Bolle wrote: > Apparently Matt left Intel. Let's forward this to a recently used > address. > > On Thu, 2016-11-03 at 10:47 +0100, Paul Bolle wrote: > > Commmit b6eea87fc685 ("x86, boot: Explicitly include autoconf.h for > > hostprogs") correctly noted > >     [...] that because $(USERINCLUDE) isn't exported by > >     the top-level Makefile it's actually empty in arch/x86/boot/Makefile. > > > > So let's do the sane thing and remove the reference to that make variable. > > > > Signed-off-by: Paul Bolle > > --- > >  arch/x86/boot/Makefile | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/boot/Makefile b/arch/x86/boot/Makefile > > index 12ea8f8384f4..0d810fb15eac 100644 > > --- a/arch/x86/boot/Makefile > > +++ b/arch/x86/boot/Makefile > > @@ -65,7 +65,7 @@ clean-files += cpustr.h > >   > >  # --------------------------------------------------------------------------- > >   > > -KBUILD_CFLAGS := $(USERINCLUDE) $(REALMODE_CFLAGS) -D_SETUP > > +KBUILD_CFLAGS := $(REALMODE_CFLAGS) -D_SETUP > >  KBUILD_AFLAGS := $(KBUILD_CFLAGS) -D__ASSEMBLY__ > >  GCOV_PROFILE := n > >  UBSAN_SANITIZE := n Looks OK to me. Reviewed-by: Matt Fleming